Commit d83384e5 authored by Wei Li's avatar Wei Li Committed by Commit Bot

Fix ui_devtools client address

Our dev tools used '0.0.0.0' as client address which doesn't work
on Windows. See some silimar discussion at
https://github.com/senecajs/seneca-transport/issues/37. Since we
don't have any remote server discovery in place, it would be
sufficient to use local host address '127.0.0.1' for showing the
local client address on chrome://inspect page. Thus this CL fixes
the client address by replacing with local host address.

BUG=750191

Change-Id: Ife011e59316b472af3e56036d539282dd6667247
Reviewed-on: https://chromium-review.googlesource.com/1249271Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595121}
parent ab70ca4f
......@@ -104,7 +104,8 @@ UiDevToolsServer::GetClientNamesAndUrls() {
i++) {
pairs.push_back(std::pair<std::string, std::string>(
devtools_server_->clients_[i]->name(),
base::StringPrintf("%s0.0.0.0:%d/%" PRIuS, kChromeDeveloperToolsPrefix,
base::StringPrintf("%s127.0.0.1:%d/%" PRIuS,
kChromeDeveloperToolsPrefix,
devtools_server_->port(), i)));
}
return pairs;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment