Revert "Set touch action Auto in MaybeSendSyntheticTapGesture"

This reverts commit ec552f22.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 583369 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWM1NTJmMjI5NTM5NzM4NzFjZWExZTYyNWNmNmIzNjZjOGMzNjM0NQw

Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71344

Sample Failed Step: mash_browser_tests (with patch)

Sample Flaky Test: ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF

Original change's description:
> Set touch action Auto in MaybeSendSyntheticTapGesture
> 
> The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent,
> in which case the TouchActionFilter::allowed_touch_action_ has no value
> and will result in a crash.
> 
> This CL set the allowed_touch_action_ to auto to fix the issue. A
> browser test is added.
> 
> Bug: 873211
> Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a
> Reviewed-on: https://chromium-review.googlesource.com/1169585
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583369}

Change-Id: I2b4c4fb6b76a7a904603e7bf1086fe4f42d9f1e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873211, 874667
Reviewed-on: https://chromium-review.googlesource.com/1176503
Cr-Commit-Position: refs/heads/master@{#583438}

chrome/browser/chrome_site_per_process_browsertest.cc

@@ -397,23 +397,6 @@ class ChromeSitePerProcessPDFTest : public ChromeSitePerProcessTest {
   }
 
   void ResendGestureToEmbedder(const std::string& host_name) {
-    content::WebContents* guest_web_contents = SetupGuestWebContents(host_name);
-    blink::WebGestureEvent event(blink::WebInputEvent::kGestureScrollUpdate,
-                                 blink::WebInputEvent::kNoModifiers,
-                                 ui::EventTimeForNow(),
-                                 blink::kWebGestureDeviceTouchscreen);
-    // This should not crash.
-    content::ResendGestureScrollUpdateToEmbedder(guest_web_contents, event);
-  }
-
-  void SendSyntheticTapGesture(const std::string& host_name) {
-    content::WebContents* guest_web_contents = SetupGuestWebContents(host_name);
-    // This should not crash
-    MaybeSendSyntheticTapGesture(guest_web_contents);
-  }
-
- private:
-  content::WebContents* SetupGuestWebContents(const std::string& host_name) {
     // Navigate to a page with an <iframe>.
     GURL main_url(embedded_test_server()->GetURL("a.com", "/iframe.html"));
     ui_test_utils::NavigateToURL(browser(), main_url);
@@ -437,9 +420,15 @@ class ChromeSitePerProcessPDFTest : public ChromeSitePerProcessTest {
     ResetTouchAction(
         guest_view::GuestViewBase::FromWebContents(guest_web_contents)
             ->GetOwnerRenderWidgetHost());
-    return guest_web_contents;
+    blink::WebGestureEvent event(blink::WebInputEvent::kGestureScrollUpdate,
+                                 blink::WebInputEvent::kNoModifiers,
+                                 ui::EventTimeForNow(),
+                                 blink::kWebGestureDeviceTouchscreen);
+    // This should not crash.
+    content::ResendGestureScrollUpdateToEmbedder(guest_web_contents, event);
   }
 
+ private:
   guest_view::TestGuestViewManagerFactory factory_;
   guest_view::TestGuestViewManager* test_guest_view_manager_;
 
@@ -460,19 +449,6 @@ IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessPDFTest,
   ResendGestureToEmbedder("a.com");
 }
 
-// Regression test for https://crbug.com/873211. MaybeSendSyntheticTapGesture
-// can be called with no touch action set in TouchActionFilter and results in
-// a crash.
-IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessPDFTest,
-                       SendSyntheticTapGestureOOPIF) {
-  SendSyntheticTapGesture("b.com");
-}
-
-IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessPDFTest,
-                       SendSyntheticTapGestureNonOOPIF) {
-  SendSyntheticTapGesture("a.com");
-}
-
 // This test verifies that when navigating an OOPIF to a page with <embed>-ed
 // PDF, the guest is properly created, and by removing the embedder frame, the
 // guest is properly destroyed (https://crbug.com/649856).

content/browser/frame_host/render_widget_host_view_guest.cc

@@ -620,12 +620,6 @@ RenderWidgetHostViewGuest::GetOwnerRenderWidgetHostView() const {
                 : nullptr;
 }
 
-void RenderWidgetHostViewGuest::MaybeSendSyntheticTapGestureForTest(
-    const blink::WebFloatPoint& position,
-    const blink::WebFloatPoint& screenPosition) const {
-  MaybeSendSyntheticTapGesture(position, screenPosition);
-}
-
 // TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
 // http://crbug.com/533069
 void RenderWidgetHostViewGuest::MaybeSendSyntheticTapGesture(
@@ -647,13 +641,6 @@ void RenderWidgetHostViewGuest::MaybeSendSyntheticTapGesture(
     gesture_tap_event.SetPositionInWidget(
         blink::WebFloatPoint(position.x + offset.x(), position.y + offset.y()));
     gesture_tap_event.SetPositionInScreen(screenPosition);
-    // The touch action may not be set yet because this is still at the
-    // Pre-processing stage of a mouse or a touch event. In this case, set the
-    // touch action to Auto to prevent crashing.
-    static_cast<RenderWidgetHostImpl*>(
-        GetOwnerRenderWidgetHostView()->GetRenderWidgetHost())
-        ->input_router()
-        ->ForceSetTouchActionAuto();
     GetOwnerRenderWidgetHostView()->ProcessGestureEvent(
         gesture_tap_event, ui::LatencyInfo(ui::SourceEventType::TOUCH));
 

content/browser/frame_host/render_widget_host_view_guest.h

@@ -162,10 +162,6 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
   viz::ScopedSurfaceIdAllocator DidUpdateVisualProperties(
       const cc::RenderFrameMetadata& metadata) override;
 
-  void MaybeSendSyntheticTapGestureForTest(
-      const blink::WebFloatPoint& position,
-      const blink::WebFloatPoint& screenPosition) const;
-
  private:
   friend class RenderWidgetHostView;
 

content/public/test/browser_test_utils.cc

@@ -42,7 +42,6 @@
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
-#include "content/browser/frame_host/render_widget_host_view_guest.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
@@ -608,15 +607,6 @@ void ResendGestureScrollUpdateToEmbedder(WebContents* guest_web_contents,
   guest_web_contents->GetBrowserPluginGuest()->ResendEventToEmbedder(event);
 }
 
-void MaybeSendSyntheticTapGesture(WebContents* guest_web_contents) {
-  content::RenderWidgetHostViewGuest* rwhv =
-      static_cast<content::RenderWidgetHostViewGuest*>(
-          guest_web_contents->GetRenderWidgetHostView());
-  DCHECK(rwhv);
-  rwhv->MaybeSendSyntheticTapGestureForTest(blink::WebFloatPoint(1, 1),
-                                            blink::WebFloatPoint(1, 1));
-}
-
 void WaitForLoadStopWithoutSuccessCheck(WebContents* web_contents) {
   // In many cases, the load may have finished before we get here.  Only wait if
   // the tab still has a pending navigation.

content/public/test/browser_test_utils.h

@@ -270,10 +270,6 @@ void ResetTouchAction(RenderWidgetHost* host);
 void ResendGestureScrollUpdateToEmbedder(WebContents* guest_web_contents,
                                          const blink::WebInputEvent& event);
 
-// When a guest view is pre-processing a mouse/touch event, send a synthetic
-// tap gesture to its RenderWidgetHostView.
-void MaybeSendSyntheticTapGesture(WebContents* guest_web_contents);
-
 // Holds down modifier keys for the duration of its lifetime and releases them
 // upon destruction. This allows simulating multiple input events without
 // simulating modifier key releases in between.