Disable BFCache on tests that use unload events

Unload events never fire for documents that are put into the
BackForwardCache, so these tests won't work with bfcache turned on.

Change-Id: I5db67e2d014f993e27764bae841323207191a72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883352Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711603}

chrome/browser/password_manager/credential_manager_browsertest.cc

@@ -214,6 +214,9 @@ class CredentialManagerBrowserTest : public PasswordManagerBrowserTestBase {
   // the call to store() triggered from the unload handler.
   void TestStoreInUnloadHandlerForCrossSiteNavigation(
       bool preestablish_mojo_pipe) {
+    WebContents()->GetController().GetBackForwardCache().DisableForTesting(
+        content::BackForwardCache::TEST_USES_UNLOAD_EVENT);
+
     const GURL a_url = https_test_server().GetURL("a.com", "/title1.html");
     const GURL b_url = https_test_server().GetURL("b.com", "/title2.html");
 

content/browser/frame_host/render_frame_host_manager_browsertest.cc

@@ -3667,6 +3667,12 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest, CtrlClickSubframeLink) {
 // See https://crbug.com/577449.
 IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
                        UnloadPushStateOnCrossProcessNavigation) {
+  shell()
+      ->web_contents()
+      ->GetController()
+      .GetBackForwardCache()
+      .DisableForTesting(content::BackForwardCache::TEST_USES_UNLOAD_EVENT);
+
   StartEmbeddedServer();
   WebContentsImpl* web_contents =
       static_cast<WebContentsImpl*>(shell()->web_contents());

content/browser/site_per_process_unload_browsertest.cc

@@ -724,6 +724,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, PartialUnloadHandler) {
 //          [6]            [14] |
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
                        PendingDeletionCheckCompletedOnSubtree) {
+  web_contents()->GetController().GetBackForwardCache().DisableForTesting(
+      content::BackForwardCache::TEST_USES_UNLOAD_EVENT);
+
   GURL url_1(embedded_test_server()->GetURL(
       "a.com",
       "/cross_site_iframe_factory.html?a(a,a,a(a),a(a),a(a),a(a,a),a(a,a))"));

testing/buildbot/filters/bfcache.browser_tests.filter

@@ -15,9 +15,5 @@
 # https://chromium-swarm.appspot.com/task?id=48104c14d9892f10
 -BookmarksCommandManagerTest.All
 
-# Time out since the removal of bfcache timed eviction. Probably waiting on the
-# RenderFrameHost deletion.
--CredentialManagerBrowserTest.StoreInUnloadHandler_CrossSite_OnDemandMojoPipe
-
 # https://crbug.com/1017594
 -IsolatedAppTest.CrossProcessClientRedirect

testing/buildbot/filters/bfcache.content_browsertests.filter

@@ -20,8 +20,6 @@
 # Test expects the RenderFrameHost to be deleted after a navigation. It is now
 # stored into the BackForwardCache instead. It isn't deleted.
 -RenderFrameHostManagerTest.CleanupOnCrossProcessNavigation
--SitePerProcessBrowserTest.PendingDeletionCheckCompletedOnSubtree
--SitePerProcessBrowserTest.SlowUnloadHandlerInIframe
 -WebContentsBindingSetBrowserTest.CloseOnFrameDeletion
 
 # Wait for the old process to exit. It won't, because it is still used by a
@@ -32,7 +30,6 @@
 -RenderFrameHostManagerTest.NavigateWithUnassignedSiteInstance
 -RenderFrameHostManagerTest.RestoreFileAccessForHistoryNavigation
 -RenderFrameHostManagerTest.RestoreSubframeFileAccessForHistoryNavigation
--RenderFrameHostManagerTest.UnloadPushStateOnCrossProcessNavigation
 -RenderProcessHostTest.KeepAliveRendererProcess
 -SitePerProcessBrowserTest.SubframePendingAndBackToSameSiteInstance
 -SitePerProcessBrowserTest.SwapOutACKArrivesPriorToProcessShutdownRequest