Delete default constructor for MediaQueryEvaluator.

It always returns true for every media query. Make sure it's not used
by accident. The LocalFrame was available for all uses of it in tests.

Change-Id: If99c0ac3251c0cbf775d39e292758d7c246d410a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230481Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775046}

third_party/blink/renderer/core/css/active_style_sheets_test.cc

@@ -24,12 +24,12 @@ namespace blink {
 
 class ActiveStyleSheetsTest : public PageTestBase {
  protected:
-  static CSSStyleSheet* CreateSheet(const String& css_text = String()) {
+  CSSStyleSheet* CreateSheet(const String& css_text = String()) {
     auto* contents = MakeGarbageCollected<StyleSheetContents>(
         MakeGarbageCollected<CSSParserContext>(
             kHTMLStandardMode, SecureContextMode::kInsecureContext));
     contents->ParseString(css_text);
-    contents->EnsureRuleSet(MediaQueryEvaluator(),
+    contents->EnsureRuleSet(MediaQueryEvaluator(GetDocument().GetFrame()),
                             kRuleHasDocumentSecurityOrigin);
     return MakeGarbageCollected<CSSStyleSheet>(contents);
   }
@@ -123,8 +123,9 @@ TEST_F(ActiveStyleSheetsTest, CompareActiveStyleSheets_Mutated) {
       std::make_pair(sheet3, &sheet3->Contents()->GetRuleSet()));
 
   sheet2->Contents()->ClearRuleSet();
-  sheet2->Contents()->EnsureRuleSet(MediaQueryEvaluator(),
-                                    kRuleHasDocumentSecurityOrigin);
+  sheet2->Contents()->EnsureRuleSet(
+      MediaQueryEvaluator(GetDocument().GetFrame()),
+      kRuleHasDocumentSecurityOrigin);
 
   EXPECT_NE(old_sheets[1].second, &sheet2->Contents()->GetRuleSet());
 
@@ -404,7 +405,7 @@ TEST_F(ActiveStyleSheetsTest, CompareActiveStyleSheets_AddRemoveNonMatchingMQ) {
   scoped_refptr<MediaQuerySet> mq =
       MediaQueryParser::ParseMediaQuerySet("(min-width: 9000px)", nullptr);
   sheet1->SetMediaQueries(mq);
-  sheet1->MatchesMediaQueries(MediaQueryEvaluator());
+  sheet1->MatchesMediaQueries(MediaQueryEvaluator(GetDocument().GetFrame()));
 
   new_sheets.push_back(std::make_pair(sheet1, nullptr));
 

third_party/blink/renderer/core/css/css_test_helpers.cc

@@ -49,7 +49,7 @@ CSSRuleList* TestStyleSheet::CssRules() {
 
 RuleSet& TestStyleSheet::GetRuleSet() {
   RuleSet& rule_set = style_sheet_->Contents()->EnsureRuleSet(
-      MediaQueryEvaluator(), kRuleHasNoSpecialState);
+      MediaQueryEvaluator(document_->GetFrame()), kRuleHasNoSpecialState);
   rule_set.CompactRulesIfNeeded();
   return rule_set;
 }

third_party/blink/renderer/core/css/media_query_evaluator.h

@@ -60,8 +60,7 @@ class CORE_EXPORT MediaQueryEvaluator final
  public:
   static void Init();
 
-  // Creates evaluator which evaluates to true for all media queries.
-  MediaQueryEvaluator() = default;
+  MediaQueryEvaluator() = delete;
 
   // Creates evaluator which evaluates only simple media queries
   // Evaluator returns true for acceptedMediaType and returns true for any media

third_party/blink/renderer/core/css/resolver/style_cascade_test.cc

@@ -285,8 +285,8 @@ class StyleCascadeTest : public PageTestBase,
     CSSStyleSheet* sheet =
         CSSStyleSheet::Create(GetDocument(), init, exception_state);
     sheet->replaceSync(css_text, exception_state);
-    sheet->Contents()->EnsureRuleSet(MediaQueryEvaluator(),
-                                     kRuleHasNoSpecialState);
+    sheet->Contents()->EnsureRuleSet(
+        MediaQueryEvaluator(GetDocument().GetFrame()), kRuleHasNoSpecialState);
     return sheet;
   }
 

third_party/blink/renderer/core/css/style_engine_test.cc

@@ -88,8 +88,9 @@ StyleEngineTest::ScheduleInvalidationsForRules(TreeScope& tree_scope,
           kHTMLStandardMode, SecureContextMode::kInsecureContext));
   sheet->ParseString(css_text);
   HeapHashSet<Member<RuleSet>> rule_sets;
-  RuleSet& rule_set = sheet->EnsureRuleSet(MediaQueryEvaluator(),
-                                           kRuleHasDocumentSecurityOrigin);
+  RuleSet& rule_set =
+      sheet->EnsureRuleSet(MediaQueryEvaluator(GetDocument().GetFrame()),
+                           kRuleHasDocumentSecurityOrigin);
   rule_set.CompactRulesIfNeeded();
   if (rule_set.NeedsFullRecalcForRuleSetInvalidation())
     return kRuleSetInvalidationFullRecalc;

third_party/blink/renderer/core/loader/resource/css_style_sheet_resource_test.cc

@@ -151,7 +151,8 @@ TEST_F(CSSStyleSheetResourceTest,
   contents->CheckLoaded();
   EXPECT_TRUE(contents->IsCacheableForResource());
 
-  contents->EnsureRuleSet(MediaQueryEvaluator(), kRuleHasNoSpecialState);
+  contents->EnsureRuleSet(MediaQueryEvaluator(GetDocument().GetFrame()),
+                          kRuleHasNoSpecialState);
   EXPECT_TRUE(contents->HasRuleSet());
 
   css_resource->SaveParsedStyleSheet(contents);