Commit d8729e7d authored by Daniel Hosseinian's avatar Daniel Hosseinian Committed by Commit Bot

Disable PrintSettingsDeathTest.IsColorModelSelectedUnknown on Win ASAN

Death tests as a whole seem to be flaking on Win ASAN. Disable this test
until crbug.com/1075661 is resolved.

Bug: 1074293
Change-Id: I3b4bb4053852c184fb55630202daee552fb03424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204418Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769342}
parent a8366fba
......@@ -5,6 +5,7 @@
#include "printing/print_settings.h"
#include "base/test/gtest_util.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace printing {
......@@ -14,7 +15,13 @@ TEST(PrintSettingsTest, IsColorModelSelected) {
EXPECT_TRUE(IsColorModelSelected(IsColorModelSelected(model).has_value()));
}
TEST(PrintSettingsDeathTest, IsColorModelSelectedUnknown) {
// Flaky on Windows ASAN. See crbug.com/1074293.
#if defined(OS_WIN) && defined(ADDRESS_SANITIZER)
#define MAYBE_IsColorModelSelectedUnknown DISABLED_IsColorModelSelectedUnknown
#else
#define MAYBE_IsColorModelSelectedUnknown IsColorModelSelectedUnknown
#endif
TEST(PrintSettingsDeathTest, MAYBE_IsColorModelSelectedUnknown) {
::testing::FLAGS_gtest_death_test_style = "threadsafe";
EXPECT_DCHECK_DEATH(IsColorModelSelected(UNKNOWN_COLOR_MODEL));
EXPECT_DCHECK_DEATH(IsColorModelSelected(UNKNOWN_COLOR_MODEL - 1));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment