Commit d877f204 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Revert "Make autocorrect=off and spellcheck=false disable Touch Bar typing suggestions."

This reverts commit bf1f5892.

Reason for revert: It's not clear why we want this, see discussion on bug.
(And it prevents typing suggestions and emojis in gmail.)

Original change's description:
> Make autocorrect=off and spellcheck=false disable Touch Bar typing suggestions.
>
> Bug: 1024914
> Change-Id: I3ff68438b028fe38ad7270d7f90772b595f4f46e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917603
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715401}

TBR=avi@chromium.org,sdy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1024914
Change-Id: Ib14cd55fde1af09cd2485d86724ce480fa431c10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079174
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745193}
parent 2cbb7e2a
...@@ -2194,9 +2194,7 @@ extern NSString* NSTextInputReplacementRangeAttributeName; ...@@ -2194,9 +2194,7 @@ extern NSString* NSTextInputReplacementRangeAttributeName;
} }
- (NSTouchBar*)makeTouchBar { - (NSTouchBar*)makeTouchBar {
if (_textInputType != ui::TEXT_INPUT_TYPE_NONE && if (_textInputType != ui::TEXT_INPUT_TYPE_NONE) {
!(_textInputFlags & blink::kWebTextInputFlagAutocorrectOff) &&
!(_textInputFlags & blink::kWebTextInputFlagSpellcheckOff)) {
_candidateListTouchBarItem.reset([[NSCandidateListTouchBarItem alloc] _candidateListTouchBarItem.reset([[NSCandidateListTouchBarItem alloc]
initWithIdentifier:NSTouchBarItemIdentifierCandidateList]); initWithIdentifier:NSTouchBarItemIdentifierCandidateList]);
auto* candidateListItem = _candidateListTouchBarItem.get(); auto* candidateListItem = _candidateListTouchBarItem.get();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment