Commit d877f8a9 authored by Nico Weber's avatar Nico Weber

Work on getting things built with -Wimplicit-fallthrough. This CL was uploaded by git cl split.

Bug: 177475
R=meacer@chromium.org

Change-Id: Iaa60724d160144a2aa74c49dca0be44229f29ccd
Reviewed-on: https://chromium-review.googlesource.com/889818Reviewed-by: default avatarMustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532105}
parent 3a1d4855
...@@ -118,6 +118,7 @@ void BadClockUI::HandleCommand(SecurityInterstitialCommand command) { ...@@ -118,6 +118,7 @@ void BadClockUI::HandleCommand(SecurityInterstitialCommand command) {
case CMD_REPORT_PHISHING_ERROR: case CMD_REPORT_PHISHING_ERROR:
// Not supported by the bad clock error page. // Not supported by the bad clock error page.
NOTREACHED() << "Unsupported command: " << command; NOTREACHED() << "Unsupported command: " << command;
break;
case CMD_ERROR: case CMD_ERROR:
case CMD_TEXT_FOUND: case CMD_TEXT_FOUND:
case CMD_TEXT_NOT_FOUND: case CMD_TEXT_NOT_FOUND:
......
...@@ -96,6 +96,7 @@ void MITMSoftwareUI::HandleCommand(SecurityInterstitialCommand command) { ...@@ -96,6 +96,7 @@ void MITMSoftwareUI::HandleCommand(SecurityInterstitialCommand command) {
case CMD_REPORT_PHISHING_ERROR: case CMD_REPORT_PHISHING_ERROR:
// Not supported by the SSL error page. // Not supported by the SSL error page.
NOTREACHED() << "Unsupported command: " << command; NOTREACHED() << "Unsupported command: " << command;
break;
case CMD_ERROR: case CMD_ERROR:
case CMD_TEXT_FOUND: case CMD_TEXT_FOUND:
case CMD_TEXT_NOT_FOUND: case CMD_TEXT_NOT_FOUND:
......
...@@ -119,8 +119,9 @@ void SafeBrowsingLoudErrorUI::HandleCommand( ...@@ -119,8 +119,9 @@ void SafeBrowsingLoudErrorUI::HandleCommand(
controller()->Proceed(); controller()->Proceed();
break; break;
} }
// If the user can't proceed, fall through to CMD_DONT_PROCEED.
FALLTHROUGH;
} }
// If the user can't proceed, fall through to CMD_DONT_PROCEED.
case CMD_DONT_PROCEED: { case CMD_DONT_PROCEED: {
// User pressed on the button to return to safety. // User pressed on the button to return to safety.
// Don't record the user action here because there are other ways of // Don't record the user action here because there are other ways of
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment