Migrate off BrowserThread::DeleteSoon in /headless

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=johannes@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I0d64a4d78e73c5adfdb7f62b0be377a3a4b4cdf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895648
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711781}

headless/lib/browser/headless_browser_context_impl.cc

@@ -54,8 +54,8 @@ HeadlessBrowserContextImpl::~HeadlessBrowserContextImpl() {
   web_contents_map_.clear();
 
   if (request_context_manager_) {
-    content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE,
-                                       request_context_manager_.release());
+    base::DeleteSoon(FROM_HERE, {content::BrowserThread::IO},
+                     request_context_manager_.release());
   }
 
   ShutdownStoragePartitions();

headless/lib/browser/headless_browser_impl.cc

@@ -63,9 +63,8 @@ void HeadlessBrowserImpl::Shutdown() {
   weak_ptr_factory_.InvalidateWeakPtrs();
   browser_contexts_.clear();
   if (system_request_context_manager_) {
-    content::BrowserThread::DeleteSoon(
-        content::BrowserThread::IO, FROM_HERE,
-        system_request_context_manager_.release());
+    base::DeleteSoon(FROM_HERE, {content::BrowserThread::IO},
+                     system_request_context_manager_.release());
   }
   browser_main_parts_->QuitMainMessageLoop();
 }

headless/test/test_network_interceptor.cc

@@ -173,7 +173,7 @@ TestNetworkInterceptor::TestNetworkInterceptor() {
 }
 
 TestNetworkInterceptor::~TestNetworkInterceptor() {
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, impl_.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, impl_.release());
   interceptor_.reset();
 }