Commit d89bc84d authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/ui/passwords.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug: 925652
Change-Id: I93fc68a67fcc5df2c1547465fe5bed33eeb2868e
Reviewed-on: https://chromium-review.googlesource.com/c/1437826
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626477}
parent 160df140
......@@ -565,10 +565,10 @@ TEST_P(ManagePasswordsBubbleModelManageLinkTest, OnManageClicked) {
password_manager::ManagePasswordsReferrer::kManagePasswordsBubble);
}
INSTANTIATE_TEST_CASE_P(Default,
ManagePasswordsBubbleModelManageLinkTest,
::testing::Values(TestSyncService::SyncedTypes::ALL,
TestSyncService::SyncedTypes::NONE));
INSTANTIATE_TEST_SUITE_P(Default,
ManagePasswordsBubbleModelManageLinkTest,
::testing::Values(TestSyncService::SyncedTypes::ALL,
TestSyncService::SyncedTypes::NONE));
// Verify that URL keyed metrics are properly recorded.
TEST_F(ManagePasswordsBubbleModelTest, RecordUKMs) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment