Commit d8a36d2b authored by Matt Mueller's avatar Matt Mueller Committed by Commit Bot

Quic: Add histogram for key update reason.

Bug: b/170619368
Change-Id: I9ff06c3ef7dee571936dee89ab5e45c64163b1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488906Reviewed-by: default avatarDavid Schinazi <dschinazi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820370}
parent 33858b58
...@@ -2504,6 +2504,8 @@ void QuicChromiumClientSession::OnKeyUpdate(quic::KeyUpdateReason reason) { ...@@ -2504,6 +2504,8 @@ void QuicChromiumClientSession::OnKeyUpdate(quic::KeyUpdateReason reason) {
net_log_.AddEventWithStringParams(NetLogEventType::QUIC_SESSION_KEY_UPDATE, net_log_.AddEventWithStringParams(NetLogEventType::QUIC_SESSION_KEY_UPDATE,
"reason", "reason",
quic::KeyUpdateReasonString(reason)); quic::KeyUpdateReasonString(reason));
base::UmaHistogramEnumeration("Net.QuicSession.KeyUpdate.Reason", reason);
} }
void QuicChromiumClientSession::OnProofValid( void QuicChromiumClientSession::OnProofValid(
......
...@@ -61312,6 +61312,15 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf ...@@ -61312,6 +61312,15 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf
<int value="13668" label="kUnitConversionResult"/> <int value="13668" label="kUnitConversionResult"/>
</enum> </enum>
<enum name="QuicKeyUpdateReason">
<int value="0" label="kInvalid"/>
<int value="1" label="kRemote"/>
<int value="2" label="kLocalForTests"/>
<int value="3" label="kLocalForInteropRunner"/>
<int value="4" label="kLocalAeadConfidentialityLimit"/>
<int value="5" label="kLocalKeyUpdateLimitOverride"/>
</enum>
<enum name="QuickofficeErrorTypes"> <enum name="QuickofficeErrorTypes">
<int value="0" label="doc uncaught js exception"/> <int value="0" label="doc uncaught js exception"/>
<int value="1" label="docx uncaught js exception"/> <int value="1" label="docx uncaught js exception"/>
...@@ -2952,6 +2952,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -2952,6 +2952,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary> </summary>
</histogram> </histogram>
<histogram name="Net.QuicSession.KeyUpdate.Reason" enum="QuicKeyUpdateReason"
expires_after="2021-05-11">
<owner>mattm@chromium.org</owner>
<owner>src/net/quic/OWNERS</owner>
<summary>The reason why each key update occured.</summary>
</histogram>
<histogram <histogram
name="Net.QuicSession.LastInFlightPacketSentTimeFromHandshakeCompletionWithPublicReset" name="Net.QuicSession.LastInFlightPacketSentTimeFromHandshakeCompletionWithPublicReset"
units="ms" expires_after="2021-05-11"> units="ms" expires_after="2021-05-11">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment