Commit d8cbcb4e authored by skuhne's avatar skuhne Committed by Commit bot

Fixing flakiness of 2 AppActivityTest's

This was caused by some very slow running trybots. If the test was running significantly slower
than a second, a MemoryPressureNotifier event was able to be sent, which caused the ResourceManager
to perform some asynchronous action which is not wanted for these unit tests.

BUG=412537, 417189
TEST=AppActivityTes.TestUnloadProxyLocation, AppActivityTest.TestMultipleActivityUnloadLock

Review URL: https://codereview.chromium.org/598033004

Cr-Commit-Position: refs/heads/master@{#296545}
parent 4a14c008
...@@ -310,8 +310,10 @@ TEST_F(AppActivityTest, TestUnloadFollowedByClose) { ...@@ -310,8 +310,10 @@ TEST_F(AppActivityTest, TestUnloadFollowedByClose) {
// Test that when unloading an app while multiple apps / activities are present, // Test that when unloading an app while multiple apps / activities are present,
// the proxy gets created in the correct location. // the proxy gets created in the correct location.
// Flaky: http://crbug.com/416843. TEST_F(AppActivityTest, TestUnloadProxyLocation) {
TEST_F(AppActivityTest, DISABLED_TestUnloadProxyLocation) { // Disable the resource manager since some build bots run this test for an
// extended amount of time which allows the MemoryPressureNotifier to fire.
DisableResourceManager();
// Set up some activities for some applications. // Set up some activities for some applications.
TestAppActivity* app_activity1a = CreateAppActivity(kDummyApp1); TestAppActivity* app_activity1a = CreateAppActivity(kDummyApp1);
TestAppActivity* app_activity2a = CreateAppActivity(kDummyApp2); TestAppActivity* app_activity2a = CreateAppActivity(kDummyApp2);
...@@ -344,8 +346,11 @@ TEST_F(AppActivityTest, DISABLED_TestUnloadProxyLocation) { ...@@ -344,8 +346,11 @@ TEST_F(AppActivityTest, DISABLED_TestUnloadProxyLocation) {
// Test that an unload with multiple activities of the same app will only unload // Test that an unload with multiple activities of the same app will only unload
// when all activities were marked for unloading. // when all activities were marked for unloading.
// Flaky: http://crbug.com/417189. TEST_F(AppActivityTest, TestMultipleActivityUnloadLock) {
TEST_F(AppActivityTest, DISABLED_TestMultipleActivityUnloadLock) { // Disable the resource manager since some build bots run this test for an
// extended amount of time which allows the MemoryPressureNotifier to fire.
DisableResourceManager();
EXPECT_EQ(0, AppRegistry::Get()->NumberOfApplications()); EXPECT_EQ(0, AppRegistry::Get()->NumberOfApplications());
TestAppActivity* app_activity1 = CreateAppActivity(kDummyApp1); TestAppActivity* app_activity1 = CreateAppActivity(kDummyApp1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment