Commit d9060444 authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

Add UMA for time over deadline in Find-in-Page Scoping

Bug: 868227
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4dc042dbcf7e38b71a64d1caa2982110e2796fef
Reviewed-on: https://chromium-review.googlesource.com/1193602Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587239}
parent 5ce358a7
...@@ -61,6 +61,7 @@ ...@@ -61,6 +61,7 @@
#include "third_party/blink/renderer/core/layout/layout_view.h" #include "third_party/blink/renderer/core/layout/layout_view.h"
#include "third_party/blink/renderer/core/layout/text_autosizer.h" #include "third_party/blink/renderer/core/layout/text_autosizer.h"
#include "third_party/blink/renderer/core/page/page.h" #include "third_party/blink/renderer/core/page/page.h"
#include "third_party/blink/renderer/platform/histogram.h"
#include "third_party/blink/renderer/platform/timer.h" #include "third_party/blink/renderer/platform/timer.h"
#include "third_party/blink/renderer/platform/wtf/time.h" #include "third_party/blink/renderer/platform/wtf/time.h"
...@@ -431,6 +432,9 @@ void TextFinder::ScopeStringMatches(IdleDeadline* deadline, ...@@ -431,6 +432,9 @@ void TextFinder::ScopeStringMatches(IdleDeadline* deadline,
return; return;
} }
const TimeDelta time_available =
TimeDelta::FromMillisecondsD(deadline->timeRemaining());
const TimeTicks start_time = CurrentTimeTicks();
PositionInFlatTree search_start = PositionInFlatTree::FirstPositionInNode( PositionInFlatTree search_start = PositionInFlatTree::FirstPositionInNode(
*OwnerFrame().GetFrame()->GetDocument()); *OwnerFrame().GetFrame()->GetDocument());
PositionInFlatTree search_end = PositionInFlatTree::LastPositionInNode( PositionInFlatTree search_end = PositionInFlatTree::LastPositionInNode(
...@@ -528,6 +532,10 @@ void TextFinder::ScopeStringMatches(IdleDeadline* deadline, ...@@ -528,6 +532,10 @@ void TextFinder::ScopeStringMatches(IdleDeadline* deadline,
next_scoping_start = search_start; next_scoping_start = search_start;
} while (deadline->timeRemaining() > 0); } while (deadline->timeRemaining() > 0);
const TimeDelta time_spent = CurrentTimeTicks() - start_time;
UMA_HISTOGRAM_TIMES("WebCore.FindInPage.ScopingTime",
time_spent - time_available);
if (next_scoping_start.IsNotNull()) { if (next_scoping_start.IsNotNull()) {
resume_scoping_from_range_ = resume_scoping_from_range_ =
Range::Create(*next_scoping_start.GetDocument(), Range::Create(*next_scoping_start.GetDocument(),
......
...@@ -112988,6 +112988,14 @@ uploading your change for review. ...@@ -112988,6 +112988,14 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="WebCore.FindInPage.ScopingTime">
<owner>rakina@chromium.org</owner>
<summary>
Records how much time it takes for find-in-page scoping over the idle task
deadline.
</summary>
</histogram>
<histogram name="WebCore.Framebust" enum="FramebustPermissions"> <histogram name="WebCore.Framebust" enum="FramebustPermissions">
<owner>japhet@chromium.org</owner> <owner>japhet@chromium.org</owner>
<summary> <summary>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment