Commit d9336191 authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

[CodeHealth] Add comments to cc::ScrollTimeline::ScrollDirection

cc::ScrollTimeline::ScrollDirection uses different enums from the spec
because it does not know about the writing modes. Adding comments to
reduce ambiguity.

Bug: None
Change-Id: I1f9bf443df42d52a1a5bd9960423d2fa94d4f565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949113
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: default avatarMajid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721161}
parent 570141f5
...@@ -22,6 +22,10 @@ class ScrollTree; ...@@ -22,6 +22,10 @@ class ScrollTree;
// https://wicg.github.io/scroll-animations/#scrolltimeline-interface. // https://wicg.github.io/scroll-animations/#scrolltimeline-interface.
class CC_ANIMATION_EXPORT ScrollTimeline { class CC_ANIMATION_EXPORT ScrollTimeline {
public: public:
// cc does not know about writing modes. The ScrollDirection below is
// converted using blink::scroll_timeline_util::ConvertOrientation which takes
// the spec-compliant ScrollDirection enumeration.
// https://drafts.csswg.org/scroll-animations/#scrolldirection-enumeration
enum ScrollDirection { enum ScrollDirection {
ScrollUp, ScrollUp,
ScrollDown, ScrollDown,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment