Commit d95b57fe authored by Alice Wang's avatar Alice Wang Committed by Commit Bot

[Android][Test] Batch AccountPickerBottomSheetTest

This CL batches AccountPickerBottomSheetTest.

Bug: 1120258
Change-Id: I0f6ae90b8863aa3dafed3d016086e2f19cca3aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376816Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801810}
parent d397ec53
...@@ -43,6 +43,7 @@ import org.mockito.Mock; ...@@ -43,6 +43,7 @@ import org.mockito.Mock;
import org.chromium.base.Callback; import org.chromium.base.Callback;
import org.chromium.base.ThreadUtils; import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Batch;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.app.ChromeActivity; import org.chromium.chrome.browser.app.ChromeActivity;
...@@ -52,6 +53,7 @@ import org.chromium.chrome.browser.signin.account_picker.AccountPickerBottomShee ...@@ -52,6 +53,7 @@ import org.chromium.chrome.browser.signin.account_picker.AccountPickerBottomShee
import org.chromium.chrome.browser.signin.account_picker.AccountPickerDelegate; import org.chromium.chrome.browser.signin.account_picker.AccountPickerDelegate;
import org.chromium.chrome.test.ChromeActivityTestRule; import org.chromium.chrome.test.ChromeActivityTestRule;
import org.chromium.chrome.test.ChromeJUnit4ClassRunner; import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.chrome.test.batch.BlankCTATabInitialStateRule;
import org.chromium.chrome.test.util.browser.Features; import org.chromium.chrome.test.util.browser.Features;
import org.chromium.chrome.test.util.browser.signin.AccountManagerTestRule; import org.chromium.chrome.test.util.browser.signin.AccountManagerTestRule;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController; import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
...@@ -72,6 +74,7 @@ import org.chromium.ui.test.util.DisableAnimationsTestRule; ...@@ -72,6 +74,7 @@ import org.chromium.ui.test.util.DisableAnimationsTestRule;
@RunWith(ChromeJUnit4ClassRunner.class) @RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE}) @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE})
@Features.EnableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY}) @Features.EnableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
@Batch(Batch.PER_CLASS)
public class AccountPickerBottomSheetTest { public class AccountPickerBottomSheetTest {
private static class CustomFakeProfileDataSource extends FakeProfileDataSource { private static class CustomFakeProfileDataSource extends FakeProfileDataSource {
int getNumberOfObservers() { int getNumberOfObservers() {
...@@ -93,10 +96,14 @@ public class AccountPickerBottomSheetTest { ...@@ -93,10 +96,14 @@ public class AccountPickerBottomSheetTest {
public static final DisableAnimationsTestRule sNoAnimationsRule = public static final DisableAnimationsTestRule sNoAnimationsRule =
new DisableAnimationsTestRule(); new DisableAnimationsTestRule();
@Rule @ClassRule
public final ChromeActivityTestRule<ChromeActivity> mActivityTestRule = public static final ChromeActivityTestRule<ChromeActivity> sActivityTestRule =
new ChromeActivityTestRule<>(ChromeActivity.class); new ChromeActivityTestRule<>(ChromeActivity.class);
@Rule
public final BlankCTATabInitialStateRule mInitialStateRule =
new BlankCTATabInitialStateRule(sActivityTestRule, false);
private final CustomFakeProfileDataSource mFakeProfileDataSource = private final CustomFakeProfileDataSource mFakeProfileDataSource =
new CustomFakeProfileDataSource(); new CustomFakeProfileDataSource();
...@@ -117,7 +124,6 @@ public class AccountPickerBottomSheetTest { ...@@ -117,7 +124,6 @@ public class AccountPickerBottomSheetTest {
initMocks(this); initMocks(this);
mAccountManagerTestRule.addAccount(PROFILE_DATA1); mAccountManagerTestRule.addAccount(PROFILE_DATA1);
mAccountManagerTestRule.addAccount(PROFILE_DATA2); mAccountManagerTestRule.addAccount(PROFILE_DATA2);
mActivityTestRule.startMainActivityOnBlankPage();
} }
@Test @Test
...@@ -476,7 +482,7 @@ public class AccountPickerBottomSheetTest { ...@@ -476,7 +482,7 @@ public class AccountPickerBottomSheetTest {
onView(allOf(withId(R.id.account_selection_mark), withEffectiveVisibility(VISIBLE))) onView(allOf(withId(R.id.account_selection_mark), withEffectiveVisibility(VISIBLE)))
.check(matches(isDisplayed())); .check(matches(isDisplayed()));
String continueAsText = String continueAsText =
mActivityTestRule.getActivity().getString(R.string.signin_promo_continue_as, sActivityTestRule.getActivity().getString(R.string.signin_promo_continue_as,
profileData.getGivenName() != null ? profileData.getGivenName() profileData.getGivenName() != null ? profileData.getGivenName()
: profileData.getAccountName()); : profileData.getAccountName());
onView(withText(continueAsText)).check(matches(isDisplayed())); onView(withText(continueAsText)).check(matches(isDisplayed()));
...@@ -485,7 +491,7 @@ public class AccountPickerBottomSheetTest { ...@@ -485,7 +491,7 @@ public class AccountPickerBottomSheetTest {
private void buildAndShowCollapsedBottomSheet() { private void buildAndShowCollapsedBottomSheet() {
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
mCoordinator = new AccountPickerBottomSheetCoordinator(mActivityTestRule.getActivity(), mCoordinator = new AccountPickerBottomSheetCoordinator(sActivityTestRule.getActivity(),
getBottomSheetController(), mAccountPickerDelegateMock); getBottomSheetController(), mAccountPickerDelegateMock);
}); });
CriteriaHelper.pollUiThread(mCoordinator.getBottomSheetViewForTesting().findViewById( CriteriaHelper.pollUiThread(mCoordinator.getBottomSheetViewForTesting().findViewById(
...@@ -498,7 +504,7 @@ public class AccountPickerBottomSheetTest { ...@@ -498,7 +504,7 @@ public class AccountPickerBottomSheetTest {
} }
private BottomSheetController getBottomSheetController() { private BottomSheetController getBottomSheetController() {
return mActivityTestRule.getActivity() return sActivityTestRule.getActivity()
.getRootUiCoordinatorForTesting() .getRootUiCoordinatorForTesting()
.getBottomSheetController(); .getBottomSheetController();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment