Commit d95e135e authored by Andrey Kosyakov's avatar Andrey Kosyakov Committed by Commit Bot

Do not open about:blank when being driven by debugger

We don't want stray web contents being present.

Change-Id: I29f243e83c7379add99b75e6c7baa7bfbf530c6e
Reviewed-on: https://chromium-review.googlesource.com/1135991
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575004}
parent d65a0f7d
......@@ -180,19 +180,23 @@ void HeadlessShell::OnStart(HeadlessBrowser* browser) {
base::CommandLine::StringVector args =
base::CommandLine::ForCurrentProcess()->GetArgs();
// TODO(alexclarke): Should we navigate to about:blank first if using
// virtual time?
if (args.empty())
// If no explicit URL is present, navigate to about:blank, unless we're being
// driven by debugger.
if (args.empty() && !base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kRemoteDebuggingPipe)) {
#if defined(OS_WIN)
args.push_back(L"about:blank");
#else
args.push_back("about:blank");
#endif
}
base::PostTaskAndReplyWithResult(
file_task_runner_.get(), FROM_HERE,
base::BindOnce(&ConvertArgumentsToURLs, args),
base::BindOnce(&HeadlessShell::OnGotURLs, weak_factory_.GetWeakPtr()));
if (!args.empty()) {
base::PostTaskAndReplyWithResult(
file_task_runner_.get(), FROM_HERE,
base::BindOnce(&ConvertArgumentsToURLs, args),
base::BindOnce(&HeadlessShell::OnGotURLs, weak_factory_.GetWeakPtr()));
}
}
void HeadlessShell::OnGotURLs(const std::vector<GURL>& urls) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment