Commit d9620cbf authored by Jamie Walch's avatar Jamie Walch Committed by Commit Bot

Fix remote assistance on macOS with Chrome 78.

https://chromium-review.googlesource.com/c/chromium/src/+/1773861
changed the top-level bundle name to end in .app, since .bundle names
are not supported by the accessibility prefpane. However, it didn't go
far enough, as although ChromeRemoteDesktopHost is the bundle named in
the permissions prompt, it is the nested bundle, RemoteAssistanceHost,
that needs to be whitelisted.

This CL fixes this by renaming both the remote assistance and remote
access native messaging components to end in .app (the latter is not
necessary to fix this bug, but it shouldn't cause any problems and it
makes them consistent).

Users who upgrade Chrome to M78 and attempt to use remote assistance
before installing this CRD update will end up in a broken state because
the system will fail to whitelist the old RemoteAssistanceHost.bundle,
but will remember prompting the user and so will not do so again when
it is renamed to RemoteAssistanceHost.app. To avoid this, this CL also
changes the signing identity for RemoteAssistanceHost.app, which will
cause the system to ask for approval again. The signing identity for
the remote access native messaging component is not changed, because it
doesn't do anything that would cause it to be put onto any permissions
list.

Bug: 996993
Change-Id: If11ad4d2559e5a40f2f2b8c5ee98b630a976ac02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776699
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: default avatarLambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691848}
parent 39f325ed
...@@ -11,9 +11,9 @@ MAC_HOST_BUNDLE_NAME=ChromeRemoteDesktopHost.app ...@@ -11,9 +11,9 @@ MAC_HOST_BUNDLE_NAME=ChromeRemoteDesktopHost.app
MAC_HOST_LEGACY_BUNDLE_NAME=ChromeRemoteDesktopHost.bundle MAC_HOST_LEGACY_BUNDLE_NAME=ChromeRemoteDesktopHost.bundle
MAC_HOST_PACKAGE_NAME=Chrome Remote Desktop Host MAC_HOST_PACKAGE_NAME=Chrome Remote Desktop Host
MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=com.google.chrome.remote_desktop.native-messaging-host MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=com.google.chrome.remote_desktop.native-messaging-host
MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.bundle MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.app
MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=com.google.chrome.remote_desktop.remote-assistance-host MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=com.google.chrome.remote_desktop.remote-assistance-host-v2
MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.bundle MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.app
MAC_UNINSTALLER_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host-uninstaller MAC_UNINSTALLER_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host-uninstaller
MAC_UNINSTALLER_BUNDLE_PREFIX=com.google.pkg MAC_UNINSTALLER_BUNDLE_PREFIX=com.google.pkg
MAC_UNINSTALLER_NAME=Chrome Remote Desktop Host Uninstaller MAC_UNINSTALLER_NAME=Chrome Remote Desktop Host Uninstaller
......
...@@ -11,9 +11,9 @@ MAC_HOST_BUNDLE_NAME=ChromotingHost.app ...@@ -11,9 +11,9 @@ MAC_HOST_BUNDLE_NAME=ChromotingHost.app
MAC_HOST_LEGACY_BUNDLE_NAME=ChromotingHost.bundle MAC_HOST_LEGACY_BUNDLE_NAME=ChromotingHost.bundle
MAC_HOST_PACKAGE_NAME=Chromoting Host MAC_HOST_PACKAGE_NAME=Chromoting Host
MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=org.chromium.chromoting.native-messaging-host MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=org.chromium.chromoting.native-messaging-host
MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.bundle MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.app
MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=org.chromium.chromoting.remote-assistance-host MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=org.chromium.chromoting.remote-assistance-host-v2
MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.bundle MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.app
MAC_UNINSTALLER_BUNDLE_ID=org.chromium.chromoting.me2me-host-uninstaller MAC_UNINSTALLER_BUNDLE_ID=org.chromium.chromoting.me2me-host-uninstaller
MAC_UNINSTALLER_BUNDLE_PREFIX=org.chromium.pkg MAC_UNINSTALLER_BUNDLE_PREFIX=org.chromium.pkg
MAC_UNINSTALLER_NAME=Chromoting Host Uninstaller MAC_UNINSTALLER_NAME=Chromoting Host Uninstaller
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment