Commit d98edb03 authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Disable Flaky OmniboxPopupTestCase Tests on iPhone Sim

TBR=stkhapugin@chromium.org

Bug: 1128463
Change-Id: I939bbb3883f1ece20bc357d53e5c603e2589f0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521702Reviewed-by: default avatarSebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824879}
parent e5492075
...@@ -146,14 +146,14 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( ...@@ -146,14 +146,14 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
} }
// Tests that the switch to open tab button isn't displayed for the current tab. // Tests that the switch to open tab button isn't displayed for the current tab.
- (void)testNotSwitchButtonOnCurrentTab { // TODO(crbug.com/1128463): Test is flaky on simulators.
// TODO(crbug.com/1128463): Test is flaky on iPad simulator.
#if TARGET_IPHONE_SIMULATOR #if TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) { #define MAYBE_testNotSwitchButtonOnCurrentTab \
EARL_GREY_TEST_SKIPPED(@"This test is flaky on iPad simulators."); DISABLED_testNotSwitchButtonOnCurrentTab
} #else
#define MAYBE_testNotSwitchButtonOnCurrentTab testNotSwitchButtonOnCurrentTab
#endif #endif
- (void)MAYBE_testNotSwitchButtonOnCurrentTab {
// TODO(crbug.com/1067817): Test won't pass on iPad devices. // TODO(crbug.com/1067817): Test won't pass on iPad devices.
#if !TARGET_IPHONE_SIMULATOR #if !TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) { if ([ChromeEarlGrey isIPadIdiom]) {
...@@ -276,14 +276,15 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( ...@@ -276,14 +276,15 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
[ChromeEarlGrey waitForMainTabCount:1]; [ChromeEarlGrey waitForMainTabCount:1];
} }
- (void)testDontCloseNTPWhenSwitchingWithForwardHistory { // TODO(crbug.com/1128463): Test is flaky on simulators.
// TODO(crbug.com/1128463): Test is flaky on iPad simulator.
#if TARGET_IPHONE_SIMULATOR #if TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) { #define MAYBE_testDontCloseNTPWhenSwitchingWithForwardHistory \
EARL_GREY_TEST_SKIPPED(@"This test is flaky on iPad simulators."); DISABLED_testDontCloseNTPWhenSwitchingWithForwardHistory
} #else
#define MAYBE_testDontCloseNTPWhenSwitchingWithForwardHistory \
testDontCloseNTPWhenSwitchingWithForwardHistory
#endif #endif
- (void)MAYBE_testDontCloseNTPWhenSwitchingWithForwardHistory {
// TODO(crbug.com/1067817): Test won't pass on iPad devices. // TODO(crbug.com/1067817): Test won't pass on iPad devices.
#if !TARGET_IPHONE_SIMULATOR #if !TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) { if ([ChromeEarlGrey isIPadIdiom]) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment