Commit d99ae5c1 authored by Omer Katz's avatar Omer Katz Committed by Commit Bot

heap: Use fullpaths in clang plugin ignored/allowed directories

Using just the suffix results in applying the clang plugin to Oilpan
source code if the chromium checkout resides (transitively) under a
directory named "test". In such cases, chromium fails to build.

Bug: 1137252
Change-Id: I6a0e7fb5e175c9f33fe7c79ca7f5790b69eb34ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480569Reviewed-by: default avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818383}
parent b3664811
...@@ -88,8 +88,10 @@ BlinkGCPluginConsumer::BlinkGCPluginConsumer( ...@@ -88,8 +88,10 @@ BlinkGCPluginConsumer::BlinkGCPluginConsumer(
options_.checked_namespaces.insert("blink"); options_.checked_namespaces.insert("blink");
// Ignore GC implementation files. // Ignore GC implementation files.
options_.ignored_directories.push_back("/heap/"); options_.ignored_directories.push_back(
options_.allowed_directories.push_back("/test/"); "third_party/blink/renderer/platform/heap/");
options_.allowed_directories.push_back(
"third_party/blink/renderer/platform/heap/test/");
} }
void BlinkGCPluginConsumer::HandleTranslationUnit(ASTContext& context) { void BlinkGCPluginConsumer::HandleTranslationUnit(ASTContext& context) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment