Commit d9a0e1c2 authored by Tetsui Ohkubo's avatar Tetsui Ohkubo Committed by Commit Bot

Adjust style of ARC migration successful notification.

This CL makes style changes to ARC migration successful notification.

- Add new material design icon to ARC migration successful
  notification.
- Remove old icon on the right side.
- Add title and adjust message string.

This CL corresponds with https://crrev.com/c/666597 , which makes
similar changes to ARC migration notification ("Install OS update").

TEST=manual
BUG=775818

Change-Id: If483a86e932af3a8463bd282db3d325a9984c4a2
Reviewed-on: https://chromium-review.googlesource.com/725025Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509969}
parent b3a03f16
......@@ -5152,8 +5152,11 @@ Battery full
<message name="IDS_ARC_MIGRATE_ENCRYPTION_NOTIFICATION_RESTART_BUTTON" desc="Label for the button in the notification that navigates the user to sign-out for completing the encryption update step.">
Sign out &amp; sign back in
</message>
<message name="IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_TITLE" desc="Title of the toast shown on the first sign-in after the successfully completed migration needed for using Android apps.">
OS update successful
</message>
<message name="IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_MESSAGE" desc="Message of the toast shown on the first sign-in after the successfully completed migration needed for using Android apps.">
Update successful. You can now use Android apps.
You can now use Android apps.
</message>
<message name="IDS_VOICE_INTERACTION_VALUE_PROP_LOADING" desc="Loading message of the voice interaction value prop dialog.">
Loading Google Assistant...
......
......@@ -56,16 +56,31 @@ class ArcMigrationGuideNotificationDelegate
void DoShowArcMigrationSuccessNotification(
const message_center::NotifierId& notifier_id) {
message_center::MessageCenter::Get()->AddNotification(
std::make_unique<message_center::Notification>(
message_center::NOTIFICATION_TYPE_SIMPLE, kSuccessNotificationId,
base::string16(), // title
l10n_util::GetStringUTF16(IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_MESSAGE),
gfx::Image(gfx::CreateVectorIcon(
kArcMigrateEncryptionNotificationIcon, gfx::kPlaceholderColor)),
base::string16(), GURL(), notifier_id,
message_center::RichNotificationData(),
new message_center::NotificationDelegate()));
if (message_center::IsNewStyleNotificationEnabled()) {
message_center::MessageCenter::Get()->AddNotification(
message_center::Notification::CreateSystemNotification(
message_center::NOTIFICATION_TYPE_SIMPLE, kSuccessNotificationId,
l10n_util::GetStringUTF16(IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_TITLE),
l10n_util::GetStringUTF16(
IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_MESSAGE),
gfx::Image(), base::string16(), GURL(), notifier_id,
message_center::RichNotificationData(),
new message_center::NotificationDelegate(),
ash::kNotificationSettingsIcon,
message_center::SystemNotificationWarningLevel::NORMAL));
} else {
message_center::MessageCenter::Get()->AddNotification(
std::make_unique<message_center::Notification>(
message_center::NOTIFICATION_TYPE_SIMPLE, kSuccessNotificationId,
l10n_util::GetStringUTF16(IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_TITLE),
l10n_util::GetStringUTF16(
IDS_ARC_MIGRATE_ENCRYPTION_SUCCESS_MESSAGE),
gfx::Image(gfx::CreateVectorIcon(
kArcMigrateEncryptionNotificationIcon, gfx::kPlaceholderColor)),
base::string16(), GURL(), notifier_id,
message_center::RichNotificationData(),
new message_center::NotificationDelegate()));
}
}
} // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment