Commit d9dfced1 authored by Ilia Samsonov's avatar Ilia Samsonov Committed by Commit Bot

Fix ClearLogoOnSignOut flakiness

ClearLogoOnSignOut sometime fails due RunLoop exiting early.

The initial SetCachedLogo(nullptr) call from SignIn might not run.

Bug: 1003172
Change-Id: I46df0b4461f8e974160f22cbdf08ce1cba2280f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799032Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#696053}
parent a112c7c7
...@@ -960,6 +960,8 @@ TEST_F(LogoServiceImplTest, DeleteExpiredCachedLogo) { ...@@ -960,6 +960,8 @@ TEST_F(LogoServiceImplTest, DeleteExpiredCachedLogo) {
TEST_F(LogoServiceImplTest, ClearLogoOnSignOut) { TEST_F(LogoServiceImplTest, ClearLogoOnSignOut) {
// Sign in and setup a logo response. // Sign in and setup a logo response.
signin_helper_.SignIn(); signin_helper_.SignIn();
// |SetCachedLogo(nullptr)| task might not have run.
task_environment_.RunUntilIdle();
Logo logo = GetSampleLogo(DoodleURL(), test_clock_.Now()); Logo logo = GetSampleLogo(DoodleURL(), test_clock_.Now());
SetServerResponse(ServerResponse(logo)); SetServerResponse(ServerResponse(logo));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment