Commit d9e4ad40 authored by Vincent Boisselle's avatar Vincent Boisselle Committed by Commit Bot

Deprecated upload_required in Autofill query request.

It will now default to USE_UPLOAD_RATES. We are planning to get rid of that field in the new API.

Change-Id: Idd7d7821d016ec13c0c7e5e03a26f94a52628d42
Reviewed-on: https://chromium-review.googlesource.com/c/1323706
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Reviewed-by: default avatarRoger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606456}
parent 3e7d4477
...@@ -287,7 +287,6 @@ HtmlFieldType FieldTypeFromAutocompleteAttributeValue( ...@@ -287,7 +287,6 @@ HtmlFieldType FieldTypeFromAutocompleteAttributeValue(
std::ostream& operator<<( std::ostream& operator<<(
std::ostream& out, std::ostream& out,
const autofill::AutofillQueryResponseContents& response) { const autofill::AutofillQueryResponseContents& response) {
out << "upload_required: " << response.upload_required();
for (const auto& field : response.field()) { for (const auto& field : response.field()) {
out << "\nautofill_type: " << field.overall_type_prediction(); out << "\nautofill_type: " << field.overall_type_prediction();
} }
...@@ -546,9 +545,6 @@ void FormStructure::ProcessQueryResponse( ...@@ -546,9 +545,6 @@ void FormStructure::ProcessQueryResponse(
// Copy the field types into the actual form. // Copy the field types into the actual form.
auto current_field = response.field().begin(); auto current_field = response.field().begin();
for (FormStructure* form : forms) { for (FormStructure* form : forms) {
form->upload_required_ =
response.upload_required() ? UPLOAD_REQUIRED : UPLOAD_NOT_REQUIRED;
bool query_response_has_no_server_data = true; bool query_response_has_no_server_data = true;
for (auto& field : form->fields_) { for (auto& field : form->fields_) {
if (form->ShouldSkipField(*field)) if (form->ShouldSkipField(*field))
......
...@@ -29,7 +29,7 @@ message AutofillQueryContents { ...@@ -29,7 +29,7 @@ message AutofillQueryContents {
// information. // information.
// Next available id: 10 // Next available id: 10
message AutofillQueryResponseContents { message AutofillQueryResponseContents {
optional bool upload_required = 1; optional bool upload_required = 1 [deprecated = true];
repeated group Field = 2 { repeated group Field = 2 {
required fixed32 overall_type_prediction = 3; required fixed32 overall_type_prediction = 3;
// Detailed list of all possible predictions (including // Detailed list of all possible predictions (including
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment