Roll closure compiler to v20201006

Removed BigInt and BigInt64Array, URLSearchParams#keys from
externs/pending.js since these have been added to the default compiler
externs.

Couple of notes:
 1) It is the first time a roll is fetching the closure compiler
    binary and externs from NPM.
 2) Any updates to chrome_extensions.js have been intentionally
    reverted from this CL, since they cause type-checking errors.
    Instead, a parallel effort is underway to stop using
    chrome_extensions.js in Chromium.

Bug: 1137293,1137350
Change-Id: I6a120b7a8e75aefa8a5dd3ce3c8d03fa33b3f745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464091
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817064}

chrome/browser/resources/ntp4/apps_page.js

@@ -618,7 +618,7 @@ cr.define('ntp', function() {
 
       this.addEventListener('tilePage:tile_added', this.onTileAdded_);
 
-      this.content_.addEventListener('scroll', this.onScroll_.bind(this));
+      this.content_.addEventListener('scroll', this.onScroll.bind(this));
     },
 
     /**
@@ -679,9 +679,9 @@ cr.define('ntp', function() {
     /**
      * A handler for when the apps page is scrolled (then we need to reposition
      * the bubbles.
-     * @private
+     * @override
      */
-    onScroll_() {
+    onScroll() {
       if (!this.selected) {
         return;
       }

chrome/browser/resources/ntp4/tile_page.js

@@ -462,7 +462,7 @@ cr.define('ntp', function() {
       this.addEventListener(
           'DOMNodeInsertedIntoDocument', this.onNodeInsertedIntoDocument_);
 
-      this.content_.addEventListener('scroll', this.onScroll_.bind(this));
+      this.content_.addEventListener('scroll', this.onScroll.bind(this));
 
       this.dragWrapper_ = new cr.ui.DragWrapper(this.tileGrid_, this);
 
@@ -1094,9 +1094,9 @@ cr.define('ntp', function() {
     /**
      * Handler for the 'scroll' event on |content_|.
      * @param {Event} e The scroll event.
-     * @private
+     * @protected
      */
-    onScroll_(e) {
+    onScroll(e) {
       this.queueUpdateScrollbars_();
     },
 

chromeos/components/camera_app_ui/resources/js/externs/w3c_api.js

@@ -14,16 +14,3 @@
  * @nosideeffects
  */
 Blob.prototype.arrayBuffer = function() {};
-
-/**
- * @see https://www.w3.org/TR/2016/WD-html51-20160310/webappapis.html#the-promiserejectionevent-interface
- * @extends {Event}
- * @constructor
- */
-const PromiseRejectionEvent = function() {};
-
-/** @type {Promise<*>} */
-PromiseRejectionEvent.prototype.promise;
-
-/** @type {*} */
-PromiseRejectionEvent.prototype.reason;

chromeos/components/media_app_ui/resources/js/dom_draft.externs.js

@@ -9,16 +9,3 @@
 
 /** @type {function(): !Promise<!ArrayBuffer>} */
 Blob.prototype.arrayBuffer;
-
-/**
- * @see https://www.w3.org/TR/2016/WD-html51-20160310/webappapis.html#the-promiserejectionevent-interface
- * @extends {Event}
- * @constructor
- */
-const PromiseRejectionEvent = function() {};
-
-/** @type {Promise<*>} */
-PromiseRejectionEvent.prototype.promise;
-
-/** @type {*} */
-PromiseRejectionEvent.prototype.reason;

mojo/public/js/BUILD.gn

@@ -112,10 +112,7 @@ if (enable_mojom_closure_compile || enable_js_type_check) {
     outputs = [ "$target_gen_dir/mojo_bindings_lite.js" ]
     sources = []
     deps = [ ":bindings_lite_sources" ]
-    externs_list = [
-      "$externs_path/mojo_core.js",
-      "$externs_path/pending.js",
-    ]
+    externs_list = [ "$externs_path/mojo_core.js" ]
     closure_flags = strict_error_checking_closure_args + [
                       "compilation_level=ADVANCED_OPTIMIZATIONS",
                       "language_in=ECMASCRIPT_2017",

mojo/public/js/bindings_lite.js

@@ -104,7 +104,7 @@ mojo.internal.setUint64 = function(dataView, byteOffset, value) {
 /**
  * @param {!DataView} dataView
  * @param {number} byteOffset
- * @return {number}
+ * @return {bigint|number}
  */
 mojo.internal.getInt64 = function(dataView, byteOffset) {
   let low, high;
@@ -225,7 +225,7 @@ mojo.internal.computeTotalArraySize = function(arraySpec, value) {
 /**
  * @param {!DataView} dataView
  * @param {number} byteOffset
- * @return {number}
+ * @return {bigint|number}
  */
 mojo.internal.getUint64 = function(dataView, byteOffset) {
   let low, high;

third_party/closure_compiler/README.chromium

 Name: Closure compiler
 Short Name: closure-compiler
 URL: http://github.com/google/closure-compiler
-Version: v20200517
-Date: 2020/06/04 19:52
+Version: 20201006.0.0
+Date: 2020/10/12 10:13
 License: Apache 2.0
 License File: LICENSE
 Security Critical: no

third_party/closure_compiler/externs/pending.js

@@ -36,16 +36,6 @@ class DOMMatrix {
   transformPoint(point) {}
 }
 
-/**
- * @see
- * https://github.com/tc39/proposal-bigint
- * This supports wrapping and operating on arbitrarily large integers.
- *
- * @param {!(number|string)} value
- * @return {number}
- */
-let BigInt = function(value) {};
-
 /**
  * TODO(katie): Remove this once length is added to the Closure
  * chrome_extensions.js.
@@ -58,42 +48,6 @@ function TtsEvent() {}
 TtsEvent.prototype.length;
 
 
-
-/**
- * @param {number|ArrayBufferView|Array.<number>|ArrayBuffer} length or array
- *     or buffer
- * @param {number=} opt_byteOffset
- * @param {number=} opt_length
- * @extends {ArrayBufferView}
- * @constructor
- * @throws {Error}
- * @modifies {arguments}
- */
-function BigInt64Array(length, opt_byteOffset, opt_length) {}
-
-/** @type {number} */
-BigInt64Array.BYTES_PER_ELEMENT;
-
-/** @type {number} */
-BigInt64Array.prototype.BYTES_PER_ELEMENT;
-
-/** @type {number} */
-BigInt64Array.prototype.length;
-
-/**
- * @param {ArrayBufferView|Array.<number>} array
- * @param {number=} opt_offset
- */
-BigInt64Array.prototype.set = function(array, opt_offset) {};
-
-/**
- * @param {number} begin
- * @param {number=} opt_end
- * @return {!BigInt64Array}
- * @nosideeffects
- */
-BigInt64Array.prototype.subarray = function(begin, opt_end) {};
-
 /**
  * @see https://drafts.css-houdini.org/css-typed-om/#stylepropertymap
  * @typedef {{set: function(string, *):void,
@@ -125,14 +79,7 @@ class StylePropertyMap {
 HTMLElement.prototype.attributeStyleMap;
 
 /** @return {!AnimationEffectTimingProperties} */
-AnimationEffectReadOnly.prototype.getTiming = function() {};
+AnimationEffect.prototype.getTiming = function() {};
 
 /** @return {!Array<!Object>} */
-AnimationEffectReadOnly.prototype.getKeyframes = function() {};
-
-/**
- * @return {!IteratorIterable<!Array<string>>}
- * @nosideeffects
- * @see https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/keys
- */
-URLSearchParams.prototype.keys = function() {};
+AnimationEffect.prototype.getKeyframes = function() {};

third_party/polymer/v1_0/chromium.patch

@@ -453,3 +453,16 @@ index 07d7d945d3a4..ca60d7e8e2a0 100644
        --paper-grey-50: #fafafa;
        --paper-grey-100: #f5f5f5;
        --paper-grey-200: #eeeeee;
+diff --git a/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js b/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
+index 9661322ca948..806a2b068933 100644
+--- a/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
++++ b/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
+@@ -20,7 +20,7 @@
+             if (!neonAnimation.configure) {
+               /**
+                * @param {Object} config
+-               * @return {AnimationEffectReadOnly}
++               * @return {AnimationEffect}
+                */
+               neonAnimation.configure = function(config) {
+                 return null;

third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js

@@ -20,7 +20,7 @@
             if (!neonAnimation.configure) {
               /**
                * @param {Object} config
-               * @return {AnimationEffectReadOnly}
+               * @return {AnimationEffect}
                */
               neonAnimation.configure = function(config) {
                 return null;