Commit d9fda94c authored by Mounir Lamouri's avatar Mounir Lamouri Committed by Commit Bot

Picture-in-Picture: disable browser tests on mash.

This will allow the browser tests to run on all platforms.

Bug: 845747
Change-Id: I07eb6fbd8240c5f559ef078538ffc047e7ab784c
Reviewed-on: https://chromium-review.googlesource.com/1105073Reviewed-by: default avatarapacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568815}
parent 76fb49b6
...@@ -61,9 +61,6 @@ class PictureInPictureWindowControllerBrowserTest ...@@ -61,9 +61,6 @@ class PictureInPictureWindowControllerBrowserTest
DISALLOW_COPY_AND_ASSIGN(PictureInPictureWindowControllerBrowserTest); DISALLOW_COPY_AND_ASSIGN(PictureInPictureWindowControllerBrowserTest);
}; };
// TODO(845747): ChromeOS is hitting this DCHECK.
#if !defined(OS_CHROMEOS)
// Checks the creation of the window controller, as well as basic window // Checks the creation of the window controller, as well as basic window
// creation and visibility. // creation and visibility.
IN_PROC_BROWSER_TEST_F(PictureInPictureWindowControllerBrowserTest, IN_PROC_BROWSER_TEST_F(PictureInPictureWindowControllerBrowserTest,
...@@ -660,5 +657,3 @@ IN_PROC_BROWSER_TEST_F(PictureInPictureWindowControllerBrowserTest, ...@@ -660,5 +657,3 @@ IN_PROC_BROWSER_TEST_F(PictureInPictureWindowControllerBrowserTest,
EXPECT_EQ(1u, active_web_contents->GetAllFrames().size()); EXPECT_EQ(1u, active_web_contents->GetAllFrames().size());
EXPECT_FALSE(window_controller()->GetWindowForTesting()->IsVisible()); EXPECT_FALSE(window_controller()->GetWindowForTesting()->IsVisible());
} }
#endif // !defined(OS_CHROMEOS)
...@@ -275,4 +275,9 @@ ...@@ -275,4 +275,9 @@
# supported in mash. crbug/834775 # supported in mash. crbug/834775
-DisplayPrefsBrowserTest.* -DisplayPrefsBrowserTest.*
# Picture-in-Picture does not work with mash because VideoSurfaceLayer is
# disabled.
# https://crbug.com/827327
-PictureInPictureWindowControllerBrowserTest.*
# See comment at top of file regarding adding test exclusions. # See comment at top of file regarding adding test exclusions.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment