Commit da0c6d87 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Do not use LoadCommittedDetails.item in VoiceSearchNavigationTabHelper.

NavigationItemCommitted is deprecated in favour of DidFinishNavigation.
This change will simplify transition from NavigationItemCommitted to
DidFinishNavigation, because DidFinishNavigation does not pass
NavigationItem as argument.

Bug: 720786
Change-Id: I758d7220c2d600bc663d8c55eeb49b5c54e619ff
Reviewed-on: https://chromium-review.googlesource.com/c/1356770
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613330}
parent 0868dc05
......@@ -48,7 +48,7 @@ void VoiceSearchNavigationTabHelper::NavigationItemCommitted(
const web::LoadCommittedDetails& load_details) {
DCHECK_EQ(web_state_, web_state);
if (will_navigate_to_voice_search_result_) {
load_details.item->SetUserData(
web_state->GetNavigationManager()->GetLastCommittedItem()->SetUserData(
kNavigationMarkerKey, std::make_unique<VoiceSearchNavigationMarker>());
will_navigate_to_voice_search_result_ = false;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment