[iOS][Credential-Provider] Specify which identifier

This also makes naming consistent with crrev.com/c/2410250.

Bug: 1090776
Change-Id: I29383a78da2847d486a706ab15aaeb5edf6048fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410484
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807030}

ios/chrome/common/credential_provider/archivable_credential_store.mm

@@ -129,10 +129,11 @@
   });
 }
 
-- (id<Credential>)credentialWithIdentifier:(NSString*)identifier {
+- (id<Credential>)credentialWithRecordIdentifier:(NSString*)recordIdentifier {
+  DCHECK(recordIdentifier.length);
   __block id<Credential> credential;
   dispatch_sync(self.workingQueue, ^{
-    credential = self.memoryStorage[identifier];
+    credential = self.memoryStorage[recordIdentifier];
   });
   return credential;
 }

ios/chrome/common/credential_provider/credential_store.h

@@ -36,8 +36,8 @@
 // to update the data on disk.
 - (void)removeCredentialWithRecordIdentifier:(NSString*)recordIdentifier;
 
-// Returns the credential with matching |identifier| or nil if none.
-- (id<Credential>)credentialWithIdentifier:(NSString*)identifier;
+// Returns the credential with matching |recordIdentifier| or nil if none.
+- (id<Credential>)credentialWithRecordIdentifier:(NSString*)recordIdentifier;
 
 @end
 

ios/chrome/credential_provider_extension/credential_provider_view_controller.mm

@@ -173,7 +173,7 @@
     (ASPasswordCredentialIdentity*)credentialIdentity {
   NSString* identifier = credentialIdentity.recordIdentifier;
   id<Credential> credential =
-      [self.credentialStore credentialWithIdentifier:identifier];
+      [self.credentialStore credentialWithRecordIdentifier:identifier];
   if (credential) {
     NSString* password =
         PasswordWithKeychainIdentifier(credential.keychainIdentifier);