Commit da1d809c authored by Caitlin Fischer's avatar Caitlin Fischer Committed by Commit Bot

Remove several studies from the config.

This is because Windows has a command line size limit and too many
testing configs can result in the limit being hit.

See comment 10 on the bug for details on why these studies are
candidates for removal.

Also, cleans up the ChromeSmartSelection feature flag.

htpp://crbug/1127065 was filed for cleaning up a test file related to
CopylessPaste, which can probably just be removed.

Bug: 1126640

Change-Id: Ib63ce18c5cdbc8832f8cd8e98c7e007c8ba322b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404940Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#805944}
parent 13929f2f
......@@ -10,7 +10,6 @@ import android.view.textclassifier.TextClassifier;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.content_public.browser.SelectionClient;
import org.chromium.content_public.browser.SelectionMetricsLogger;
import org.chromium.content_public.browser.SelectionPopupController;
......@@ -45,8 +44,7 @@ public class SelectionClientManager {
* @param webContents The {@link WebContents} that will show popups for this client.
*/
SelectionClientManager(WebContents webContents) {
if (ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_SMART_SELECTION)
&& Build.VERSION.SDK_INT > Build.VERSION_CODES.O) {
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.O) {
assert webContents != null;
mOptionalSelectionClient = SelectionClient.createSmartSelectionClient(webContents);
SelectionPopupController controller =
......
......@@ -131,7 +131,6 @@ const base::Feature* kFeaturesExposedToJava[] = {
&kChromeShareScreenshot,
&kChromeSharingHub,
&kChromeSharingHubV15,
&kChromeSmartSelection,
&kCommandLineOnNonRooted,
&kConditionalTabStripAndroid,
&kContentIndexingDownloadHome,
......@@ -381,9 +380,6 @@ const base::Feature kChromeSharingHub{"ChromeSharingHub",
const base::Feature kChromeSharingHubV15{"ChromeSharingHubV15",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kChromeSmartSelection{"ChromeSmartSelection",
base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kCommandLineOnNonRooted{"CommandLineOnNonRooted",
base::FEATURE_DISABLED_BY_DEFAULT};
......
......@@ -42,7 +42,6 @@ extern const base::Feature kChromeShareQRCode;
extern const base::Feature kChromeShareScreenshot;
extern const base::Feature kChromeSharingHub;
extern const base::Feature kChromeSharingHubV15;
extern const base::Feature kChromeSmartSelection;
extern const base::Feature kCommandLineOnNonRooted;
extern const base::Feature kConditionalTabStripAndroid;
extern const base::Feature kContentIndexingDownloadHome;
......
......@@ -243,7 +243,6 @@ public abstract class ChromeFeatureList {
public static final String CHROME_SHARE_SCREENSHOT = "ChromeShareScreenshot";
public static final String CHROME_SHARING_HUB = "ChromeSharingHub";
public static final String CHROME_SHARING_HUB_V15 = "ChromeSharingHubV15";
public static final String CHROME_SMART_SELECTION = "ChromeSmartSelection";
public static final String CLEAR_OLD_BROWSING_DATA = "ClearOldBrowsingData";
public static final String COMMAND_LINE_ON_NON_ROOTED = "CommandLineOnNonRooted";
public static final String CONDITIONAL_TAB_STRIP_ANDROID = "ConditionalTabStripAndroid";
......
......@@ -1216,21 +1216,6 @@
]
}
],
"ChromeSmartSelection": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled_Launch",
"enable_features": [
"ChromeSmartSelection"
]
}
]
}
],
"ChromeStart": [
{
"platforms": [
......@@ -1486,21 +1471,6 @@
]
}
],
"CopylessPaste": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"CopylessPaste"
]
}
]
}
],
"CrOSMinFilelistKB": [
{
"platforms": [
......@@ -1658,18 +1628,6 @@
]
}
],
"DefaultBrowserInfobar": [
{
"platforms": [
"windows"
],
"experiments": [
{
"name": "SettingsTextNotNow"
}
]
}
],
"DefaultEnableOopRasterization": [
{
"platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment