Commit da20b6a2 authored by Fabrice de Gans-Riberi's avatar Fabrice de Gans-Riberi Committed by Commit Bot

Disable TCPSocketTest.BeforeConnectCallback on Fuchsia.

This test fails becasue MSG_PEEK is not implemented.

Bug: 887587
Change-Id: I6e1ba04afc1f34a11352ba0280dfc33c4436affa
Reviewed-on: https://chromium-review.googlesource.com/1235210
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592895}
parent f218afd8
......@@ -255,7 +255,7 @@ bool SocketPosix::IsConnected() const {
// 1. Check if the connection is alive using poll(POLLRDHUP).
// 2. If closed, then use ioctl(FIONREAD) to check if there is data to be
// read.
// TODO(bug 738275): Remove once MSG_PEEK is implemented on Fuchsia.
// TODO(crbug.com/887587): Remove once MSG_PEEK is implemented on Fuchsia.
struct pollfd pollfd;
pollfd.fd = socket_fd_;
pollfd.events = POLLRDHUP;
......@@ -297,7 +297,7 @@ bool SocketPosix::IsConnectedAndIdle() const {
// socket. POLLIN is signaled if the socket is readable or if it was closed by
// the peer, i.e. the socket is connected and idle if and only if POLLIN is
// not signaled.
// TODO(bug 738275): Remove once MSG_PEEK is implemented.
// TODO(crbug.com/887587): Remove once MSG_PEEK is implemented.
struct pollfd pollfd;
pollfd.fd = socket_fd_;
pollfd.events = POLLIN;
......
......@@ -26,3 +26,7 @@
# Flaky, https://crbug.com/814811.
-URLRequestTest.NetworkDelegateProxyError
# SocketPosix::IsConnected has a different behavior on Fuchsia.
# https://crbug.com/887587.
-TCPSocketTest.BeforeConnectCallback
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment