Commit da22cad8 authored by Evan Stade's avatar Evan Stade Committed by Commit Bot

Revert "Fixed more Document leaks in Autofill"

This reverts commit cb950738.

Reason for revert: suspected of performance regression: crbug.com/825005

Original change's description:
> Fixed more Document leaks in Autofill
> 
> Some Autofill-related code can hold persistent reference to last
> changed or focused <input> element that cause leak of whole Documents
> containing such element after navigation to other page.
> 
> Some leaks fixed in https://chromium-review.googlesource.com/939224
> This CL fixes other related leaks.
> 
> Bug: 734427
> Change-Id: Ic084d0670cccb9d11595d0bde8cf0d605bfa8911
> Reviewed-on: https://chromium-review.googlesource.com/970582
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544404}

TBR=estade@chromium.org,dvadym@chromium.org,atimoxin@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734427
Change-Id: I57bd57e50af5d8e4f4d97b731a354fd7b0957966
Reviewed-on: https://chromium-review.googlesource.com/981292Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546146}
parent 5c6b2348
......@@ -968,7 +968,6 @@ bool AutofillAgent::GetSubmittedForm(FormData* form) {
void AutofillAgent::ResetLastInteractedElements() {
last_interacted_form_.Reset();
last_clicked_form_control_element_for_testing_.Reset();
formless_elements_user_edited_.clear();
provisionally_saved_form_.reset();
}
......
......@@ -143,10 +143,8 @@ void FormTracker::FormControlDidChangeImpl(
void FormTracker::DidCommitProvisionalLoad(bool is_new_navigation,
bool is_same_document_navigation) {
DCHECK_CALLED_ON_VALID_SEQUENCE(form_tracker_sequence_checker_);
if (!is_same_document_navigation) {
ResetLastInteractedElements();
if (!is_same_document_navigation)
return;
}
FireSubmissionIfFormDisappear(SubmissionSource::SAME_DOCUMENT_NAVIGATION);
}
......
......@@ -181,14 +181,6 @@ void PasswordGenerationAgent::BindRequest(
binding_.Bind(std::move(request));
}
void PasswordGenerationAgent::DidCommitProvisionalLoad(
bool /*is_new_navigation*/, bool is_same_document_navigation) {
if (is_same_document_navigation)
return;
generation_element_.Reset();
last_focused_password_element_.Reset();
}
void PasswordGenerationAgent::DidFinishDocumentLoad() {
// Update stats for main frame navigation.
if (!render_frame()->GetWebFrame()->Parent()) {
......
......@@ -94,8 +94,6 @@ class PasswordGenerationAgent : public content::RenderFrameObserver,
typedef std::vector<AccountCreationFormData> AccountCreationFormDataList;
// RenderFrameObserver:
void DidCommitProvisionalLoad(bool is_new_navigation,
bool is_same_document_navigation) override;
void DidFinishDocumentLoad() override;
void DidFinishLoad() override;
void OnDestruct() override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment