Skip to content

GitLab

T
tangled
Commit da2ae65d authored by Mugdha Lakhani's avatar Mugdha Lakhani Committed by Commit Bot
Browse files
Options

[Prerender] Add equivalent tests for NoStatePrefetch. 

PrerenderHttpAuthentication has been deleted from Prerender browsertests, and
an equivalent test added to NoStatePrefetch tests.

Please see this spreadsheet for details:
https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing

Bug: 898955
Change-Id: I539097682d2b842519538cb417c2e31ca1613f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297563
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789964}
parent 160450ca
Hide whitespace changes
Inline Side-by-side
Showing with 12 additions and 12 deletions
chrome/browser/prerender/prerender_browsertest.cc
View file @ da2ae65d
...@@ -761,14 +761,6 @@ class PrerenderBrowserTest : public test_utils::PrerenderInProcessBrowserTest { ...@@ -761,14 +761,6 @@ class PrerenderBrowserTest : public test_utils::PrerenderInProcessBrowserTest {
std::unique_ptr<content::URLLoaderInterceptor> interceptor_; std::unique_ptr<content::URLLoaderInterceptor> interceptor_;
}; };
// Renders a page that contains a prerender link to a page that contains an
// iframe with a source that requires http authentication. This should not
// prerender successfully.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderHttpAuthentication) {
PrerenderTestURL("/prerender/prerender_http_auth_container.html",
FINAL_STATUS_AUTH_NEEDED, 0);
}
// Checks that the referrer is set when prerendering. // Checks that the referrer is set when prerendering.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderReferrer) { IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderReferrer) {
PrerenderTestURL("/prerender/prerender_referrer.html", FINAL_STATUS_USED, 1); PrerenderTestURL("/prerender/prerender_referrer.html", FINAL_STATUS_USED, 1);
......
chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
View file @ da2ae65d
...@@ -1901,4 +1901,15 @@ IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, OpenTaskManager) { ...@@ -1901,4 +1901,15 @@ IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, OpenTaskManager) {
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, prefetch_page)); ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, prefetch_page));
} }
// Renders a page that contains a prerender link to a page that contains an
// img with a source that requires http authentication. This should not
// prerender successfully.
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,
PrerenderHttpAuthentication) {
GURL url =
src_server()->GetURL("/prerender/prerender_http_auth_container.html");
std::unique_ptr<TestPrerender> prerender =
PrefetchFromURL(url, FINAL_STATUS_AUTH_NEEDED);
}
} // namespace prerender } // namespace prerender
chrome/test/data/prerender/prerender_http_auth_container.html
View file @ da2ae65d
<html> <html>
<head></head> <head></head>
<body> <body>
<iframe src="/auth-basic/index.html?password=boggins&amp;realm=bog" <img src="/auth-basic/index.html?password=boggins&amp;realm=bog">
width="80%" height="600">
iframe not supported.
</iframe>
</body> </body>
</html> </html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment