Commit da5bcdac authored by Anand K. Mistry's avatar Anand K. Mistry Committed by Commit Bot

Stop recording metrics for SMB url parsing failures.

These failures are normal and expected as a result of user error.
Further, recording these parse failures pollutes the metric, which is
intended to record D-Bus mount call failures.

BUG=907207

Change-Id: I78bdf90b49a0954e87ff233679bcc24a6a298799
Reviewed-on: https://chromium-review.googlesource.com/c/1491059Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636219}
parent 7ef0d7d9
......@@ -256,8 +256,7 @@ void SmbService::CallMount(const file_system_provider::MountOptions& options,
SmbUrl parsed_url(share_path.value());
if (!parsed_url.IsValid()) {
FireMountCallback(
std::move(callback),
std::move(callback).Run(
TranslateErrorToMountResult(base::File::Error::FILE_ERROR_INVALID_URL));
return;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment