Commit da7100dd authored by Tamir Duberstein's avatar Tamir Duberstein Committed by Commit Bot

Assert after each send call

This test still fails on Fuchsia, but this should produce better errors.

Bug: 1127298
Change-Id: I9c6d18ad1ce863814628d052031b932c53fb9ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408399Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tamir Duberstein <tamird@google.com>
Cr-Commit-Position: refs/heads/master@{#806640}
parent 4a0ad889
...@@ -691,8 +691,7 @@ TEST_F(UDPSocketTest, MAYBE_JoinMulticastGroup) { ...@@ -691,8 +691,7 @@ TEST_F(UDPSocketTest, MAYBE_JoinMulticastGroup) {
mojom::UDPSocketOptionsPtr options = mojom::UDPSocketOptions::New(); mojom::UDPSocketOptionsPtr options = mojom::UDPSocketOptions::New();
options->allow_address_sharing_for_multicast = true; options->allow_address_sharing_for_multicast = true;
net::IPAddress bind_ip_address; net::IPAddress bind_ip_address = net::IPAddress::AllZeros(group_ip.size());
EXPECT_TRUE(bind_ip_address.AssignFromIPLiteral("0.0.0.0"));
net::IPEndPoint socket_address(bind_ip_address, 0); net::IPEndPoint socket_address(bind_ip_address, 0);
ASSERT_EQ(net::OK, helper.BindSync(socket_address, std::move(options), ASSERT_EQ(net::OK, helper.BindSync(socket_address, std::move(options),
&socket_address)); &socket_address));
...@@ -741,10 +740,14 @@ TEST_F(UDPSocketTest, MAYBE_JoinMulticastGroup) { ...@@ -741,10 +740,14 @@ TEST_F(UDPSocketTest, MAYBE_JoinMulticastGroup) {
// No longer can receive messages from itself or from second socket. // No longer can receive messages from itself or from second socket.
EXPECT_EQ(net::OK, helper.SendToSync(group_alias, test_msg)); EXPECT_EQ(net::OK, helper.SendToSync(group_alias, test_msg));
ASSERT_EQ(net::OK, second_socket_helper.SendToSync(group_alias, test_msg));
socket_remote->ReceiveMore(1); socket_remote->ReceiveMore(1);
socket_remote.FlushForTesting(); socket_remote.FlushForTesting();
ASSERT_EQ(2u, listener.results().size()); EXPECT_EQ(2u, listener.results().size());
EXPECT_EQ(net::OK, second_socket_helper.SendToSync(group_alias, test_msg));
socket_remote->ReceiveMore(1);
socket_remote.FlushForTesting();
EXPECT_EQ(2u, listener.results().size());
} }
TEST_F(UDPSocketTest, ErrorHappensDuringSocketOptionsConfiguration) { TEST_F(UDPSocketTest, ErrorHappensDuringSocketOptionsConfiguration) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment