Commit daa06ec1 authored by David Black's avatar David Black Committed by Commit Bot

Activate holding space bubble when opening w/ ChromeVox enabled.

When ChromeVox is enabled, the holding space bubble should be activated
on open so as to announce itself and so as to move ChromeVox focus into
the bubble.

Bug: 1137067
Change-Id: I454813ad1116a2ddb1d27e6ff6251849d5d96dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468341Reviewed-by: default avatarToni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#816707}
parent f87b6bda
...@@ -75,7 +75,8 @@ bool HoldingSpaceTray::PerformAction(const ui::Event& event) { ...@@ -75,7 +75,8 @@ bool HoldingSpaceTray::PerformAction(const ui::Event& event) {
// Activate the bubble for a11y or if it was shown via keypress. Otherwise // Activate the bubble for a11y or if it was shown via keypress. Otherwise
// focus will remain on the tray when it should enter the bubble. // focus will remain on the tray when it should enter the bubble.
if (event.IsKeyEvent() || (event.flags() & ui::EF_TOUCH_ACCESSIBILITY)) { if (event.IsKeyEvent() ||
Shell::Get()->accessibility_controller()->spoken_feedback().enabled()) {
DCHECK(bubble_ && bubble_->GetBubbleWidget()); DCHECK(bubble_ && bubble_->GetBubbleWidget());
bubble_->GetBubbleWidget()->widget_delegate()->SetCanActivate(true); bubble_->GetBubbleWidget()->widget_delegate()->SetCanActivate(true);
bubble_->GetBubbleWidget()->Activate(); bubble_->GetBubbleWidget()->Activate();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment