Add ARC libcups api chrome://flags#arc-cups-api

This cl adds a flag to toggle the support of libcups apis from ARC.
Disabled by default.

Bug: chromium:832262
Test: flag unused thus far
Change-Id: Ib745f034f0c426456e2c0777e15757629399d07a
Reviewed-on: https://chromium-review.googlesource.com/1091640
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570209}

chrome/browser/about_flags.cc

@@ -3985,6 +3985,12 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(features::kSuggestedTextTouchBar)},
 #endif
 
+#if defined(OS_CHROMEOS)
+    {"enable-arc-cups-api", flag_descriptions::kArcCupsApiName,
+     flag_descriptions::kArcCupsApiDescription, kOsCrOS,
+     FEATURE_VALUE_TYPE(features::kArcCupsApi)},
+#endif  // OS_CHROMEOS
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

chrome/browser/flag_descriptions.cc

@@ -2806,6 +2806,10 @@ const char kArcBootCompleted[] = "Load Android apps automatically";
 const char kArcBootCompletedDescription[] =
     "Allow Android apps to start automatically after signing in.";
 
+const char kArcCupsApiName[] = "ARC CUPS API";
+const char kArcCupsApiDescription[] =
+    "Enables support of libcups APIs from ARC";
+
 const char kArcNativeBridgeExperimentName[] =
     "Enable native bridge experiment for ARC";
 const char kArcNativeBridgeExperimentDescription[] =

chrome/browser/flag_descriptions.h

@@ -1715,6 +1715,9 @@ extern const char kArcAvailableForChildDescription[];
 extern const char kArcBootCompleted[];
 extern const char kArcBootCompletedDescription[];
 
+extern const char kArcCupsApiName[];
+extern const char kArcCupsApiDescription[];
+
 extern const char kArcNativeBridgeExperimentName[];
 extern const char kArcNativeBridgeExperimentDescription[];
 

chrome/common/chrome_features.cc

@@ -577,6 +577,10 @@ const base::Feature kVoiceSearchOnLocalNtp{"VoiceSearchOnLocalNtp",
 #endif
 
 #if defined(OS_CHROMEOS)
+// Enables support of libcups APIs from ARC
+const base::Feature kArcCupsApi{"ArcCupsApi",
+                                base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Enables or disables the opt-in IME menu in the language settings page.
 const base::Feature kOptInImeMenu{"OptInImeMenu",
                                   base::FEATURE_ENABLED_BY_DEFAULT};
@@ -621,7 +625,6 @@ const base::Feature kTPMFirmwareUpdate{"TPMFirmwareUpdate",
 // userInfo Gaia message.
 const base::Feature kCrOSEnableUSMUserService{"CrOSEnableUSMUserService",
                                               base::FEATURE_ENABLED_BY_DEFAULT};
-
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(OS_WIN)

chrome/common/chrome_features.h

@@ -318,6 +318,8 @@ extern const base::Feature kVoiceSearchOnLocalNtp;
 #endif
 
 #if defined(OS_CHROMEOS)
+extern const base::Feature kArcCupsApi;
+
 extern const base::Feature kOptInImeMenu;
 
 extern const base::Feature kQuickUnlockPin;

tools/metrics/histograms/enums.xml

@@ -28147,6 +28147,7 @@ from previous Chrome versions.
   <int value="606512202" label="AutofillCreditCardPopupLayout:enabled"/>
   <int value="606834606" label="force-color-profile"/>
   <int value="609112512" label="touch-selection-strategy"/>
+  <int value="609580715" label="ArcCupsApi:disabled"/>
   <int value="610545308" label="enable-potentially-annoying-security-features"/>
   <int value="624317932" label="print-pdf-as-image"/>
   <int value="624368375" label="OmniboxEntitySuggestions:enabled"/>
@@ -28527,6 +28528,7 @@ from previous Chrome versions.
       label="OmniboxUIExperimentHideSuggestionUrlTrivialSubdomains:disabled"/>
   <int value="1389729816" label="data-reduction-proxy-lo-fi"/>
   <int value="1397069250" label="NetworkService:disabled"/>
+  <int value="1403195370" label="ArcCupsApi:enabled"/>
   <int value="1405459667" label="enable-fast-text-autosizing"/>
   <int value="1406046556" label="enable-slimming-paint-v175"/>
   <int value="1406354320" label="MacViewsWebUIDialogs:enabled"/>