GMC: Fix pip button not showing up when media loading is slow.

This CL fix the issue by updating pip availability when media loading
is complete.

Bug: 1051142
Change-Id: Iea84f73aca6af85d951f4e7ca20240b597ef0ab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044657
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741693}

third_party/blink/renderer/core/html/media/html_video_element.cc

@@ -394,6 +394,8 @@ void HTMLVideoElement::OnLoadFinished() {
                            WrapWeakPersistent(this)));
     lazy_load_intersection_observer_->observe(this);
   }
+
+  UpdatePictureInPictureAvailability();
 }
 
 void HTMLVideoElement::PaintCurrentFrame(

third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc

@@ -52,11 +52,11 @@ PictureInPictureControllerImpl& PictureInPictureControllerImpl::From(
 }
 
 bool PictureInPictureControllerImpl::PictureInPictureEnabled() const {
-  return IsDocumentAllowed() == Status::kEnabled;
+  return IsDocumentAllowed(/*report_failure=*/true) == Status::kEnabled;
 }
 
 PictureInPictureController::Status
-PictureInPictureControllerImpl::IsDocumentAllowed() const {
+PictureInPictureControllerImpl::IsDocumentAllowed(bool report_failure) const {
   DCHECK(GetSupplementable());
 
   // If document has been detached from a frame, return kFrameDetached status.
@@ -75,7 +75,8 @@ PictureInPictureControllerImpl::IsDocumentAllowed() const {
   if (RuntimeEnabledFeatures::PictureInPictureAPIEnabled() &&
       !GetSupplementable()->IsFeatureEnabled(
           blink::mojom::blink::FeaturePolicyFeature::kPictureInPicture,
-          ReportOptions::kReportOnFailure)) {
+          report_failure ? ReportOptions::kReportOnFailure
+                         : ReportOptions::kDoNotReport)) {
     return Status::kDisabledByFeaturePolicy;
   }
 
@@ -98,13 +99,19 @@ PictureInPictureControllerImpl::VerifyElementAndOptions(
     }
   }
 
-  return IsElementAllowed(element);
+  return IsElementAllowed(element, /*report_failure=*/true);
 }
 
 PictureInPictureController::Status
 PictureInPictureControllerImpl::IsElementAllowed(
     const HTMLElement& element) const {
-  PictureInPictureController::Status status = IsDocumentAllowed();
+  return IsElementAllowed(element, /*report_failure=*/false);
+}
+
+PictureInPictureController::Status
+PictureInPictureControllerImpl::IsElementAllowed(const HTMLElement& element,
+                                                 bool report_failure) const {
+  PictureInPictureController::Status status = IsDocumentAllowed(report_failure);
   if (status != Status::kEnabled)
     return status;
 
@@ -199,7 +206,7 @@ void PictureInPictureControllerImpl::OnEnteredPictureInPicture(
       mojo::Remote<mojom::blink::PictureInPictureSession>(
           std::move(session_remote));
 
-  if (IsElementAllowed(*element) != Status::kEnabled) {
+  if (IsElementAllowed(*element, /*report_failure=*/true) != Status::kEnabled) {
     if (resolver) {
       resolver->Reject(MakeGarbageCollected<DOMException>(
           DOMExceptionCode::kInvalidStateError, ""));
@@ -334,7 +341,8 @@ bool PictureInPictureControllerImpl::IsEnterAutoPictureInPictureAllowed()
     return false;
 
   // Allow if video is allowed to enter Picture-in-Picture.
-  return (IsElementAllowed(*AutoPictureInPictureElement()) == Status::kEnabled);
+  return (IsElementAllowed(*AutoPictureInPictureElement(),
+                           /*report_failure=*/true) == Status::kEnabled);
 }
 
 bool PictureInPictureControllerImpl::IsExitAutoPictureInPictureAllowed() const {

third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h

@@ -51,7 +51,7 @@ class MODULES_EXPORT PictureInPictureControllerImpl
 
   // Returns whether the document associated with the controller is allowed to
   // request Picture-in-Picture.
-  Status IsDocumentAllowed() const;
+  Status IsDocumentAllowed(bool report_failure) const;
 
   // Returns whether the combination of element and options can be in
   // Picture-in-Picture.
@@ -106,6 +106,7 @@ class MODULES_EXPORT PictureInPictureControllerImpl
       mojo::PendingRemote<mojom::blink::PictureInPictureSession>,
       const gfx::Size&);
   void OnExitedPictureInPicture(ScriptPromiseResolver*) override;
+  Status IsElementAllowed(const HTMLElement&, bool report_failure) const;
 
   // Makes sure the `picture_in_picture_service_` is set. Returns whether it was
   // initialized successfully.