Commit dae45f5f authored by Alex Danilo's avatar Alex Danilo Committed by Commit Bot

Hide tooltip when activating selection menu

Selecting a file, then tabbing to the selection menu button
should hide the tooltip if the menu is activated from the
keyboard. This change explicitly hides the tooltip on menu
activation.

      behaviour is correct on desktop and real device.

Bug: 752035
Test: Ran all FilesApp browser tests. Manually verified
Change-Id: I8c13364748773da2521129e95d7edb29c4032edd
Reviewed-on: https://chromium-review.googlesource.com/c/1347958Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610328}
parent 2bbd27e2
......@@ -34,6 +34,8 @@ function SelectionMenuController(selectionMenuButton, menu) {
SelectionMenuController.prototype.onShowMenu_ = function() {
this.menu_.classList.toggle('toolbar-menu', true);
this.toggleRipple_.activated = true;
// crbug.com 752035 focus still on button, get rid of the tooltip
document.querySelector('files-tooltip').hideTooltip();
};
/**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment