Commit db00e482 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[Sheriff] Disable Flaky Headless Tests for Mac ASAN

TBR=mcasas

Bug: 1086872
Change-Id: Iacb2b15812e91c24bf66f167a0f720d2a3096147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216773Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772178}
parent d3a28b10
...@@ -212,8 +212,9 @@ class HeadlessBrowserTestWithProxy : public HeadlessBrowserTest { ...@@ -212,8 +212,9 @@ class HeadlessBrowserTestWithProxy : public HeadlessBrowserTest {
net::SpawnedTestServer proxy_server_; net::SpawnedTestServer proxy_server_;
}; };
#if defined(OS_WIN) #if defined(OS_WIN) || (defined(OS_MACOSX) && defined(ADDRESS_SANITIZER))
// TODO(crbug.com/1045971): Disabled due to flakiness. // TODO(crbug.com/1045971): Disabled due to flakiness.
// TODO(crbug.com/1086872): Disabled due to flakiness on Mac ASAN.
#define MAYBE_SetProxyConfig DISABLED_SetProxyConfig #define MAYBE_SetProxyConfig DISABLED_SetProxyConfig
#else #else
#define MAYBE_SetProxyConfig SetProxyConfig #define MAYBE_SetProxyConfig SetProxyConfig
......
...@@ -178,8 +178,9 @@ class HeadlessDevToolsClientChangeWindowBoundsTest ...@@ -178,8 +178,9 @@ class HeadlessDevToolsClientChangeWindowBoundsTest
} }
}; };
#if defined(OS_WIN) #if defined(OS_WIN) || (defined(OS_MACOSX) && defined(ADDRESS_SANITIZER))
// TODO(crbug.com/1045980): Disabled due to flakiness. // TODO(crbug.com/1045980): Disabled due to flakiness.
// TODO(crbug.com/1086872): Disabled due to flakiness on Mac ASAN.
DISABLED_HEADLESS_ASYNC_DEVTOOLED_TEST_F( DISABLED_HEADLESS_ASYNC_DEVTOOLED_TEST_F(
HeadlessDevToolsClientChangeWindowBoundsTest); HeadlessDevToolsClientChangeWindowBoundsTest);
#else #else
...@@ -1203,8 +1204,9 @@ class DevtoolsInterceptionWithAuthProxyTest ...@@ -1203,8 +1204,9 @@ class DevtoolsInterceptionWithAuthProxyTest
std::set<std::string> files_loaded_; std::set<std::string> files_loaded_;
}; };
#if defined(OS_WIN) #if defined(OS_WIN) || (defined(OS_MACOSX) && defined(ADDRESS_SANITIZER))
// TODO(crbug.com/1045980): Disabled due to flakiness. // TODO(crbug.com/1045980): Disabled due to flakiness.
// TODO(crbug.com/1086872): Disabled due to flakiness on Mac ASAN.
DISABLED_HEADLESS_ASYNC_DEVTOOLED_TEST_F(DevtoolsInterceptionWithAuthProxyTest); DISABLED_HEADLESS_ASYNC_DEVTOOLED_TEST_F(DevtoolsInterceptionWithAuthProxyTest);
#else #else
HEADLESS_ASYNC_DEVTOOLED_TEST_F(DevtoolsInterceptionWithAuthProxyTest); HEADLESS_ASYNC_DEVTOOLED_TEST_F(DevtoolsInterceptionWithAuthProxyTest);
......
...@@ -290,8 +290,9 @@ HEADLESS_ASYNC_DEVTOOLED_TEST_P( ...@@ -290,8 +290,9 @@ HEADLESS_ASYNC_DEVTOOLED_TEST_P(
HeadlessWebContentsScreenshotWindowPositionTest); HeadlessWebContentsScreenshotWindowPositionTest);
// Instantiate test case for both software and gpu compositing modes. // Instantiate test case for both software and gpu compositing modes.
#if !defined(OS_WIN) #if defined(OS_WIN) || (defined(OS_MACOSX) && defined(ADDRESS_SANITIZER))
// TODO(crbug.com/1045980): Disabled on Windows due to flakiness. // TODO(crbug.com/1045980): Disabled on Windows due to flakiness.
// TODO(crbug.com/1086872): Disabled due to flakiness on Mac ASAN.
INSTANTIATE_TEST_SUITE_P(HeadlessWebContentsScreenshotWindowPositionTests, INSTANTIATE_TEST_SUITE_P(HeadlessWebContentsScreenshotWindowPositionTests,
HeadlessWebContentsScreenshotWindowPositionTest, HeadlessWebContentsScreenshotWindowPositionTest,
::testing::Bool()); ::testing::Bool());
......
...@@ -194,7 +194,9 @@ class HeadlessProtocolBrowserTest ...@@ -194,7 +194,9 @@ class HeadlessProtocolBrowserTest
}; };
// TODO(crbug.com/867447): The whole test suite is extremely flaky on Win dbg. // TODO(crbug.com/867447): The whole test suite is extremely flaky on Win dbg.
#if defined(OS_WIN) && !defined(NDEBUG) // TODO(crbug.com/1086872): The whole test suite is flaky on Mac ASAN.
#if (defined(OS_WIN) && !defined(NDEBUG)) || \
(defined(OS_MACOSX) && defined(ADDRESS_SANITIZER))
#define HEADLESS_PROTOCOL_TEST(TEST_NAME, SCRIPT_NAME) \ #define HEADLESS_PROTOCOL_TEST(TEST_NAME, SCRIPT_NAME) \
IN_PROC_BROWSER_TEST_F(HeadlessProtocolBrowserTest, DISABLED_##TEST_NAME) { \ IN_PROC_BROWSER_TEST_F(HeadlessProtocolBrowserTest, DISABLED_##TEST_NAME) { \
test_folder_ = "/protocol/"; \ test_folder_ = "/protocol/"; \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment