Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4...
Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ ) Reason for revert: broke official-* bots, see crbug.com/716330 Original issue's description: > [WebAPKs] Make WebAPK update flow more sensible > > Previously, whenever the shell_apk in shell_apk_version.gni there was a period > of time during which > - Chrome tries to update the WebAPK because the "shell_apk" version with which > Chrome is compiled with was updated > - The WebAPK server is unable to fulfill the update request because the new > ShellAPK has not yet been uploaded to the WebAPK server > > This CL splits shell_apk_version in shell_apk_version.gni into two variables: > |template_shell_apk_version| and |expected_shell_apk_version| > > The new flow for updating android/webapk/shell_apk will be: > 1) Write CL which: > - Makes changes to code in android/webapk/shell_apk > - Increments |template_shell_apk_version| > This will: > - Update the template ShellAPK which is built on the official build bot > - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to > be updated > - Does not affect the "WebAPK update logic". > 2) Upload new ShellAPK template to the WebAPK Minting Server > At this point: > - new WebAPK installs will have the updated shell. > - Chrome will still not request updates to the new ShellAPK version > 3) Write CL which: > - Increments |expected_shell_apk_version| > This will: > - cause Chrome to request updates to the new ShellAPK version > > BUG=708053 > > Review-Url: https://codereview.chromium.org/2827233006 > Cr-Commit-Position: refs/heads/master@{#467708} > Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448 TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708053 Review-Url: https://codereview.chromium.org/2845943006 Cr-Commit-Position: refs/heads/master@{#467966}
Showing
Please register or sign in to comment