Commit db08d35e authored by timvolodine's avatar timvolodine Committed by Commit bot

Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4...

Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ )

Reason for revert:
broke official-* bots, see crbug.com/716330

Original issue's description:
> [WebAPKs] Make WebAPK update flow more sensible
>
> Previously, whenever the shell_apk in shell_apk_version.gni there was a period
> of time during which
> - Chrome tries to update the WebAPK because the "shell_apk" version with which
>   Chrome is compiled with was updated
> - The WebAPK server is unable to fulfill the update request because the new
>   ShellAPK has not yet been uploaded to the WebAPK server
>
> This CL splits shell_apk_version in shell_apk_version.gni into two variables:
> |template_shell_apk_version| and |expected_shell_apk_version|
>
> The new flow for updating android/webapk/shell_apk will be:
> 1) Write CL which:
>    - Makes changes to code in android/webapk/shell_apk
>    - Increments |template_shell_apk_version|
>    This will:
>    - Update the template ShellAPK which is built on the official build bot
>    - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to
>      be updated
>    - Does not affect the "WebAPK update logic".
> 2) Upload new ShellAPK template to the WebAPK Minting Server
>    At this point:
>    - new WebAPK installs will have the updated shell.
>    - Chrome will still not request updates to the new ShellAPK version
> 3) Write CL which:
>    - Increments |expected_shell_apk_version|
>    This will:
>    - cause Chrome to request updates to the new ShellAPK version
>
> BUG=708053
>
> Review-Url: https://codereview.chromium.org/2827233006
> Cr-Commit-Position: refs/heads/master@{#467708}
> Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448

TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708053

Review-Url: https://codereview.chromium.org/2845943006
Cr-Commit-Position: refs/heads/master@{#467966}
parent 50d4cffe
...@@ -30,7 +30,7 @@ java_cpp_template("runtime_library_version_java") { ...@@ -30,7 +30,7 @@ java_cpp_template("runtime_library_version_java") {
] ]
defines = [ defines = [
"CURRENT_RUNTIME_DEX_VERSION_VALUE=$runtime_library_version", "CURRENT_RUNTIME_DEX_VERSION_VALUE=$runtime_library_version",
"CURRENT_SHELL_APK_VERSION_VALUE=$expected_shell_apk_version", "CURRENT_SHELL_APK_VERSION_VALUE=$shell_apk_version",
] ]
} }
......
...@@ -54,7 +54,7 @@ manifest_processor_template("shell_apk_manifest") { ...@@ -54,7 +54,7 @@ manifest_processor_template("shell_apk_manifest") {
output = shell_apk_manifest output = shell_apk_manifest
variables = [ variables = [
"shell_apk_version=$template_shell_apk_version", "shell_apk_version=$shell_apk_version",
"manifest_package=org.chromium.webapk", "manifest_package=org.chromium.webapk",
"runtime_host=$webapk_runtime_host", "runtime_host=$webapk_runtime_host",
"start_url=$webapk_start_url", "start_url=$webapk_start_url",
...@@ -81,7 +81,7 @@ manifest_processor_template("shell_apk_manifest_javatests") { ...@@ -81,7 +81,7 @@ manifest_processor_template("shell_apk_manifest_javatests") {
output = shell_apk_manifest_javatests output = shell_apk_manifest_javatests
variables = [ variables = [
"shell_apk_version=$template_shell_apk_version", "shell_apk_version=$shell_apk_version",
"manifest_package=org.chromium.webapk.test", "manifest_package=org.chromium.webapk.test",
"runtime_host=org.chromium.chrome", "runtime_host=org.chromium.chrome",
"start_url=https://www.template.com/home_page", "start_url=https://www.template.com/home_page",
......
...@@ -3,13 +3,5 @@ ...@@ -3,13 +3,5 @@
# found in the LICENSE file. # found in the LICENSE file.
# Must be incremented whenever code in //chrome/android/webapk/shell_apk # Must be incremented whenever code in //chrome/android/webapk/shell_apk
# (including AndroidManifest.xml) is updated. This version should be incremented # (including AndroidManifest.xml) is updated.
# prior to uploading a new ShellAPK to the WebAPK Minting Server. shell_apk_version = 3
# Does not affect Chrome.apk
template_shell_apk_version = 4
# The ShellAPK version expected by Chrome. Chrome will try to update the WebAPK
# if the WebAPK's ShellAPK version is less than |expected_shell_apk_version|.
# The version should be incremented after a new ShellAPK has been uploaded to
# the WebAPK Minting Server.
expected_shell_apk_version = 3
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment