Fix test failures of flex-one-sets-flex-basis-to-zero-px.html in Firefox

The failed checks[1] are all essentially measuring the height of a single line of Ahem text, but the original test never setting the line-height css property, so Firefox gets the default value which gives a browser-defined behavior. So the fix this in Firefox, the test can simply set 'line-height: 1' to '.flexbox > div {}'. In the end, this patch changes the 3 lines in '.flexbox > div {}' to 'font: 14px/1 Ahem;'. [1] https://wpt.fyi/results/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html?diff&filter=ADC&run_id=455370002&run_id=445640004. Bug: 1063749 Change-Id: If27a2a50ed514e42b90aea85122116961d584c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134097 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757159}

Fix test failures of flex-one-sets-flex-basis-to-zero-px.html in Firefox
The failed checks[1] are all essentially measuring the height of a single line of Ahem text, but the original test never setting the line-height css property, so Firefox gets the default value which gives a browser-defined behavior. So the fix this in Firefox, the test can simply set 'line-height: 1' to '.flexbox > div {}'. In the end, this patch changes the 3 lines in '.flexbox > div {}' to 'font: 14px/1 Ahem;'. [1] https://wpt.fyi/results/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html?diff&filter=ADC&run_id=455370002&run_id=445640004. Bug: 1063749 Change-Id: If27a2a50ed514e42b90aea85122116961d584c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134097 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757159}
db2b60f2 · Gyuyoung Kim · Commit Bot · fda664e7 · db2b60f2
Commit db2b60f2 authored Apr 07, 2020 by Gyuyoung Kim Committed by Commit Bot Apr 07, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html .../css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html +2 -3

No files found.
--- a/third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html
+++ b/third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html
 <!DOCTYPE html>
 <html>
 <title>CSS Flexbox: flex-basis with zero pixel</title>
-<link rel="help" href="https://drafts.csswg.org/css-flexbox/#flex-property">
+<link rel="help" href="https://drafts.csswg.org/css-flexbox/#flex-basis-property">
 <link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
 <link href="support/flexbox.css" rel="stylesheet">
 <meta name="assert" content="This test ensures that setting 'flex-basis' property to
@@ -9,8 +9,7 @@ zero pixel or percentage in combination with one value of both 'flex-grow' and '
 and 'writing-mode' value works properly.">
 <style>
 .flexbox > div {
-    font-family: Ahem;
+    font: 14px/1 Ahem;
-    font-size: 14px;
 }
 .flex-one-one-zero-percent {