Commit dbc761a8 authored by orenb@chromium.org's avatar orenb@chromium.org

Fixed several CHECKED_RETURN defects in ipc message utils cc

CID_COUNT=3
CID=104154,104155,104156
BUG=
TEST=
TBR=jeremy


Review URL: https://chromiumcodereview.appspot.com/10829024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98
parent 2b035305
...@@ -51,6 +51,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value, ...@@ -51,6 +51,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value,
int recursion); int recursion);
void WriteValue(Message* m, const Value* value, int recursion) { void WriteValue(Message* m, const Value* value, int recursion) {
bool result;
if (recursion > kMaxRecursionDepth) { if (recursion > kMaxRecursionDepth) {
LOG(WARNING) << "Max recursion depth hit in WriteValue."; LOG(WARNING) << "Max recursion depth hit in WriteValue.";
return; return;
...@@ -63,25 +64,29 @@ void WriteValue(Message* m, const Value* value, int recursion) { ...@@ -63,25 +64,29 @@ void WriteValue(Message* m, const Value* value, int recursion) {
break; break;
case Value::TYPE_BOOLEAN: { case Value::TYPE_BOOLEAN: {
bool val; bool val;
value->GetAsBoolean(&val); result = value->GetAsBoolean(&val);
DCHECK(result);
WriteParam(m, val); WriteParam(m, val);
break; break;
} }
case Value::TYPE_INTEGER: { case Value::TYPE_INTEGER: {
int val; int val;
value->GetAsInteger(&val); result = value->GetAsInteger(&val);
DCHECK(result);
WriteParam(m, val); WriteParam(m, val);
break; break;
} }
case Value::TYPE_DOUBLE: { case Value::TYPE_DOUBLE: {
double val; double val;
value->GetAsDouble(&val); result = value->GetAsDouble(&val);
DCHECK(result);
WriteParam(m, val); WriteParam(m, val);
break; break;
} }
case Value::TYPE_STRING: { case Value::TYPE_STRING: {
std::string val; std::string val;
value->GetAsString(&val); result = value->GetAsString(&val);
DCHECK(result);
WriteParam(m, val); WriteParam(m, val);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment