Commit dbca6182 authored by Tsuyoshi Horo's avatar Tsuyoshi Horo Committed by Commit Bot

Revert "Add a functionally equivalent NTLMv1 implementation."

This reverts commit 24f0eb87.

Reason for revert: net_unittests fails on msan bot

NtlmClientTest.Type2MessageWithTargetName
NtlmClientTest.NoTargetNameOverflowFromLength

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/3002

Original change's description:
> Add a functionally equivalent NTLMv1 implementation.
> 
> - Replacement NTLMv1 implementation.
> - In preparation for new NTLMv2 implementation.
> - Passes all unit tests and has the same behavior.
> - Adds fuzzer for NtlmClient.
> - Code is still not live.
> 
> BUG=chromium:22532
> TEST=All unit tests pass.
> 
> Change-Id: Idae533312805d21d49943fd634d54af3a93a7c00
> Reviewed-on: https://chromium-review.googlesource.com/598307
> Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
> Reviewed-by: Asanka Herath <asanka@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491611}

TBR=rsleevi@chromium.org,mmenke@chromium.org,zentaro@google.com,asanka@chromium.org

Change-Id: I21057e6a0cc43aca6249153debe47e3630df82c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:22532
Reviewed-on: https://chromium-review.googlesource.com/599140Reviewed-by: default avatarTsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491664}
parent ba8724f4
...@@ -1041,8 +1041,6 @@ component("net") { ...@@ -1041,8 +1041,6 @@ component("net") {
"ntlm/ntlm_buffer_reader.h", "ntlm/ntlm_buffer_reader.h",
"ntlm/ntlm_buffer_writer.cc", "ntlm/ntlm_buffer_writer.cc",
"ntlm/ntlm_buffer_writer.h", "ntlm/ntlm_buffer_writer.h",
"ntlm/ntlm_client.cc",
"ntlm/ntlm_client.h",
"ntlm/ntlm_constants.h", "ntlm/ntlm_constants.h",
"proxy/dhcp_proxy_script_adapter_fetcher_win.cc", "proxy/dhcp_proxy_script_adapter_fetcher_win.cc",
"proxy/dhcp_proxy_script_adapter_fetcher_win.h", "proxy/dhcp_proxy_script_adapter_fetcher_win.h",
...@@ -1799,8 +1797,6 @@ component("net") { ...@@ -1799,8 +1797,6 @@ component("net") {
"ntlm/ntlm_buffer_reader.h", "ntlm/ntlm_buffer_reader.h",
"ntlm/ntlm_buffer_writer.cc", "ntlm/ntlm_buffer_writer.cc",
"ntlm/ntlm_buffer_writer.h", "ntlm/ntlm_buffer_writer.h",
"ntlm/ntlm_client.cc",
"ntlm/ntlm_client.h",
"ntlm/ntlm_constants.h", "ntlm/ntlm_constants.h",
] ]
} }
...@@ -4902,7 +4898,6 @@ test("net_unittests") { ...@@ -4902,7 +4898,6 @@ test("net_unittests") {
"ntlm/des_unittest.cc", "ntlm/des_unittest.cc",
"ntlm/ntlm_buffer_reader_unittest.cc", "ntlm/ntlm_buffer_reader_unittest.cc",
"ntlm/ntlm_buffer_writer_unittest.cc", "ntlm/ntlm_buffer_writer_unittest.cc",
"ntlm/ntlm_client_unittest.cc",
"ntlm/ntlm_test_data.h", "ntlm/ntlm_test_data.h",
"ntlm/ntlm_unittest.cc", "ntlm/ntlm_unittest.cc",
"proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc", "proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc",
...@@ -5321,7 +5316,6 @@ test("net_unittests") { ...@@ -5321,7 +5316,6 @@ test("net_unittests") {
"ntlm/des_unittest.cc", "ntlm/des_unittest.cc",
"ntlm/ntlm_buffer_reader_unittest.cc", "ntlm/ntlm_buffer_reader_unittest.cc",
"ntlm/ntlm_buffer_writer_unittest.cc", "ntlm/ntlm_buffer_writer_unittest.cc",
"ntlm/ntlm_client_unittest.cc",
"ntlm/ntlm_test_data.h", "ntlm/ntlm_test_data.h",
"ntlm/ntlm_unittest.cc", "ntlm/ntlm_unittest.cc",
] ]
...@@ -5884,21 +5878,6 @@ fuzzer_test("net_http_stream_parser_fuzzer") { ...@@ -5884,21 +5878,6 @@ fuzzer_test("net_http_stream_parser_fuzzer") {
dict = "data/fuzzer_dictionaries/net_http_stream_parser_fuzzer.dict" dict = "data/fuzzer_dictionaries/net_http_stream_parser_fuzzer.dict"
} }
fuzzer_test("net_ntlm_ntlm_client_fuzzer") {
sources = [
"ntlm/ntlm_client_fuzzer.cc",
]
deps = [
":net_fuzzer_test_support",
":test_support",
"//base",
"//net",
"//net:net_unittests",
]
dict = "data/fuzzer_dictionaries/net_ntlm_ntlm_client_fuzzer.dict"
seed_corpus = "data/fuzzer_data/ntlm_client_fuzzer/"
}
if (!disable_brotli_filter) { if (!disable_brotli_filter) {
fuzzer_test("net_brotli_source_stream_fuzzer") { fuzzer_test("net_brotli_source_stream_fuzzer") {
sources = [ sources = [
......
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment