Cert Provisioning: Certificate renewal

Start using renewal_period_seconds field from cert provisioning
policies. Track expiration date in CertProvisioningScheduler,
provision a new certificate when necessary (according to policy),
delete renewed certificates.

Bug: 1045895
Change-Id: I756fab39c96cd8de80a5e89802533d9e3c38508d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283145Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#788589}

chrome/browser/chromeos/cert_provisioning/cert_provisioning_common.cc

@@ -7,6 +7,7 @@
 #include "base/bind_helpers.h"
 #include "base/notreached.h"
 #include "base/optional.h"
+#include "base/time/time.h"
 #include "chrome/browser/chromeos/platform_keys/platform_keys_service.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/common/pref_names.h"
@@ -53,35 +54,47 @@ bool IsFinalState(CertProvisioningWorkerState state) {
 
 //===================== CertProfile ============================================
 
+CertProfile::CertProfile(CertProfileId profile_id,
+                         std::string policy_version,
+                         bool is_va_enabled,
+                         base::TimeDelta renewal_period)
+    : profile_id(profile_id),
+      policy_version(policy_version),
+      is_va_enabled(is_va_enabled),
+      renewal_period(renewal_period) {}
+
 base::Optional<CertProfile> CertProfile::MakeFromValue(
     const base::Value& value) {
-  static_assert(kVersion == 3, "This function should be updated");
+  static_assert(kVersion == 4, "This function should be updated");
 
   const std::string* id = value.FindStringKey(kCertProfileIdKey);
   const std::string* policy_version =
       value.FindStringKey(kCertProfilePolicyVersionKey);
   base::Optional<bool> is_va_enabled =
       value.FindBoolKey(kCertProfileIsVaEnabledKey);
+  base::Optional<int> renewal_period_sec =
+      value.FindIntKey(kCertProfileRenewalPeroidSec);
+
   if (!id || !policy_version) {
     return base::nullopt;
   }
-  if (!is_va_enabled) {
-    is_va_enabled = true;
-  }
 
   CertProfile result;
   result.profile_id = *id;
   result.policy_version = *policy_version;
-  result.is_va_enabled = *is_va_enabled;
+  result.is_va_enabled = is_va_enabled.value_or(true);
+  result.renewal_period =
+      base::TimeDelta::FromSeconds(renewal_period_sec.value_or(0));
 
   return result;
 }
 
 bool CertProfile::operator==(const CertProfile& other) const {
-  static_assert(kVersion == 3, "This function should be updated");
+  static_assert(kVersion == 4, "This function should be updated");
   return ((profile_id == other.profile_id) &&
           (policy_version == other.policy_version) &&
-          (is_va_enabled == other.is_va_enabled));
+          (is_va_enabled == other.is_va_enabled) &&
+          (renewal_period == other.renewal_period));
 }
 
 bool CertProfile::operator!=(const CertProfile& other) const {
@@ -90,10 +103,11 @@ bool CertProfile::operator!=(const CertProfile& other) const {
 
 bool CertProfileComparator::operator()(const CertProfile& a,
                                        const CertProfile& b) const {
-  static_assert(CertProfile::kVersion == 3, "This function should be updated");
+  static_assert(CertProfile::kVersion == 4, "This function should be updated");
   return ((a.profile_id < b.profile_id) ||
           (a.policy_version < b.policy_version) ||
-          (a.is_va_enabled < b.is_va_enabled));
+          (a.is_va_enabled < b.is_va_enabled) ||
+          (a.renewal_period < b.renewal_period));
 }
 
 //==============================================================================
@@ -109,6 +123,15 @@ void RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
       prefs::kCertificateProvisioningStateForDevice);
 }
 
+const char* GetPrefNameForCertProfiles(CertScope scope) {
+  switch (scope) {
+    case CertScope::kUser:
+      return prefs::kRequiredClientCertificateForUser;
+    case CertScope::kDevice:
+      return prefs::kRequiredClientCertificateForDevice;
+  }
+}
+
 const char* GetPrefNameForSerialization(CertScope scope) {
   switch (scope) {
     case CertScope::kUser:

chrome/browser/chromeos/cert_provisioning/cert_provisioning_common.h

@@ -10,6 +10,7 @@
 #include "base/callback.h"
 #include "base/callback_forward.h"
 #include "base/optional.h"
+#include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/platform_keys/platform_keys_service.h"
 #include "chromeos/dbus/constants/attestation_constants.h"
@@ -66,20 +67,32 @@ using CertProfileId = std::string;
 // with definitions of RequiredClientCertificateForDevice and
 // RequiredClientCertificateForUser policies in policy_templates.json file.
 const char kCertProfileIdKey[] = "cert_profile_id";
+const char kCertProfileRenewalPeroidSec[] = "renewal_period_seconds";
 const char kCertProfilePolicyVersionKey[] = "policy_version";
 const char kCertProfileIsVaEnabledKey[] = "enable_remote_attestation_check";
 
 struct CertProfile {
+  static base::Optional<CertProfile> MakeFromValue(const base::Value& value);
+
+  CertProfile() = default;
+  // For tests.
+  CertProfile(CertProfileId profile_id,
+              std::string policy_version,
+              bool is_va_enabled,
+              base::TimeDelta renewal_period);
+
   CertProfileId profile_id;
   std::string policy_version;
   bool is_va_enabled = true;
+  // Default renewal period 0 means that a certificate will be renewed only
+  // after the previous one has expired (0 seconds before it is expires).
+  base::TimeDelta renewal_period = base::TimeDelta::FromSeconds(0);
 
   // IMPORTANT:
   // Increment this when you add/change any member in CertProfile (and update
   // all functions that fail to compile because of it).
-  static constexpr int kVersion = 3;
+  static constexpr int kVersion = 4;
 
-  static base::Optional<CertProfile> MakeFromValue(const base::Value& value);
   bool operator==(const CertProfile& other) const;
   bool operator!=(const CertProfile& other) const;
 };
@@ -90,6 +103,7 @@ struct CertProfileComparator {
 
 void RegisterProfilePrefs(PrefRegistrySimple* registry);
 void RegisterLocalStatePrefs(PrefRegistrySimple* registry);
+const char* GetPrefNameForCertProfiles(CertScope scope);
 const char* GetPrefNameForSerialization(CertScope scope);
 
 // Returns the nickname (CKA_LABEL) for keys created for the |profile_id|.

chrome/browser/chromeos/cert_provisioning/cert_provisioning_platform_keys_helpers.h

@@ -22,96 +22,150 @@ class PlatformKeysService;
 namespace chromeos {
 namespace cert_provisioning {
 
-// ========= CertProvisioningCertsWithIdsGetter ================================
+// ========= CertIterator ======================================================
 
-using GetCertsWithIdsCallback = base::OnceCallback<void(
-    base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
-        certs_with_ids,
-    const std::string& error_message)>;
+using CertIteratorForEachCallback =
+    base::RepeatingCallback<void(scoped_refptr<net::X509Certificate> cert,
+                                 const CertProfileId& cert_profile_id,
+                                 const std::string& error_message)>;
+using CertIteratorOnFinishedCallback =
+    base::OnceCallback<void(const std::string& error_message)>;
 
-// Helper class that retrieves list of all certificates in a given scope with
-// their certificate profile ids. Certificates without the id are ignored.
-class CertProvisioningCertsWithIdsGetter {
+// Iterates over all existing certificates of a given |cert_scope| and combines
+// them with their certificate provisioning ids when possible. Runs |callback|
+// on every (cert, cert_profile_id) pair that had a present and non-empty
+// |cert_profile_id|. If |error_message| is not empty, then the pair is not
+// valid.
+class CertIterator {
  public:
-  CertProvisioningCertsWithIdsGetter();
-  CertProvisioningCertsWithIdsGetter(
-      const CertProvisioningCertsWithIdsGetter&) = delete;
-  CertProvisioningCertsWithIdsGetter& operator=(
-      const CertProvisioningCertsWithIdsGetter&) = delete;
-  ~CertProvisioningCertsWithIdsGetter();
-
-  bool IsRunning() const;
-
-  void GetCertsWithIds(
-      CertScope cert_scope,
-      platform_keys::PlatformKeysService* platform_keys_service,
-      GetCertsWithIdsCallback callback);
+  CertIterator(CertScope cert_scope,
+               platform_keys::PlatformKeysService* platform_keys_service);
+  CertIterator(const CertIterator&) = delete;
+  CertIterator& operator=(const CertIterator&) = delete;
+  ~CertIterator();
+
+  // Can be called more than once. If previous iteration is not finished, it
+  // will be canceled.
+  void IterateAll(CertIteratorForEachCallback for_each_callback,
+                  CertIteratorOnFinishedCallback on_finished_callback);
+  void Cancel();
 
  private:
   void OnGetCertificatesDone(
       std::unique_ptr<net::CertificateList> existing_certs,
       const std::string& error_message);
+  void OnGetAttributeForKeyDone(scoped_refptr<net::X509Certificate> cert,
+                                const base::Optional<std::string>& attr_value,
+                                const std::string& error_message);
+  void StopIteration(const std::string& error_message);
 
-  void CollectOneResult(scoped_refptr<net::X509Certificate> cert,
-                        const base::Optional<CertProfileId>& cert_id,
-                        const std::string& error_message);
-
-  CertScope cert_scope_ = CertScope::kDevice;
-  platform_keys::PlatformKeysService* platform_keys_service_ = nullptr;
+  const CertScope cert_scope_ = CertScope::kDevice;
+  platform_keys::PlatformKeysService* const platform_keys_service_ = nullptr;
 
   size_t wait_counter_ = 0;
-  base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
-      certs_with_ids_;
-  GetCertsWithIdsCallback callback_;
+  CertIteratorForEachCallback for_each_callback_;
+  CertIteratorOnFinishedCallback on_finished_callback_;
 
   SEQUENCE_CHECKER(sequence_checker_);
-  base::WeakPtrFactory<CertProvisioningCertsWithIdsGetter> weak_factory_{this};
+  base::WeakPtrFactory<CertIterator> weak_factory_{this};
 };
 
-// ========= CertProvisioningCertDeleter =======================================
+// ========= LatestCertsWithIdsGetter ==========================================
 
-using DeleteCertsCallback =
-    base::OnceCallback<void(const std::string& error_message)>;
+using LatestCertsWithIdsGetterCallback = base::OnceCallback<void(
+    base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
+        certs_with_ids,
+    const std::string& error_message)>;
 
-// Helper class that deletes all certificates in a given scope with certificate
-// profile ids that are not specified to be kept. Certificates without the id
-// are ignored.
-class CertProvisioningCertDeleter {
+// Collects map of certificates with their certificate provisioning ids and
+// returns it via |callback|. If there are several certificates for the same id,
+// only the newest one will be stored in the map. Only one call to
+// GetCertsWithIds() for one instance is allowed.
+class LatestCertsWithIdsGetter {
  public:
-  CertProvisioningCertDeleter();
-  CertProvisioningCertDeleter(const CertProvisioningCertDeleter&) = delete;
-  CertProvisioningCertDeleter& operator=(const CertProvisioningCertDeleter&) =
-      delete;
-  ~CertProvisioningCertDeleter();
-
-  void DeleteCerts(CertScope cert_scope,
-                   platform_keys::PlatformKeysService* platform_keys_service,
-                   base::flat_set<CertProfileId> cert_profile_ids_to_keep,
-                   DeleteCertsCallback callback);
+  LatestCertsWithIdsGetter(
+      CertScope cert_scope,
+      platform_keys::PlatformKeysService* platform_keys_service);
+  LatestCertsWithIdsGetter(const LatestCertsWithIdsGetter&) = delete;
+  LatestCertsWithIdsGetter& operator=(const LatestCertsWithIdsGetter&) = delete;
+  ~LatestCertsWithIdsGetter();
+
+  // Can be called more than once. If previous task is not finished, it will be
+  // canceled.
+  void GetCertsWithIds(LatestCertsWithIdsGetterCallback callback);
+  bool IsRunning() const;
+  void Cancel();
 
  private:
-  void OnGetCertsWithIdsDone(
-      base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
-          certs_with_ids,
-      const std::string& error_message);
+  void ProcessOneCert(scoped_refptr<net::X509Certificate> new_cert,
+                      const CertProfileId& cert_profile_id,
+                      const std::string& error_message);
+  void OnIterationFinished(const std::string& error_message);
 
-  void OnRemoveCertificateDone(const std::string& error_message);
+  CertIterator iterator_;
 
-  // Keeps track of how many certificates are already processed. Calls the
-  // |callback_| when all work is done.
-  void AccountOneResult();
+  // Accumulates results that will be returned at the end via |callback_|.
+  base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
+      certs_with_ids_;
+  LatestCertsWithIdsGetterCallback callback_;
 
-  CertScope cert_scope_ = CertScope::kDevice;
-  platform_keys::PlatformKeysService* platform_keys_service_ = nullptr;
+  SEQUENCE_CHECKER(sequence_checker_);
+  base::WeakPtrFactory<LatestCertsWithIdsGetter> weak_factory_{this};
+};
 
-  size_t wait_counter_ = 0;
+// ========= CertDeleter =======================================================
+
+using CertDeleterCallback =
+    base::OnceCallback<void(const std::string& error_message)>;
+
+// Finds and deletes certificates that 1) have ids that are not in
+// |cert_profile_ids_to_keep| set or 2) have another certificate for the same
+// id with later expiration date. Only one call to DeleteCerts() for one
+// instance is allowed.
+class CertDeleter {
+ public:
+  CertDeleter(CertScope cert_scope,
+              platform_keys::PlatformKeysService* platform_keys_service);
+  CertDeleter(const CertDeleter&) = delete;
+  CertDeleter& operator=(const CertDeleter&) = delete;
+  ~CertDeleter();
+  void Cancel();
+
+  // Can be called more than once. If previous task is not finished, it will be
+  // canceled.
+  void DeleteCerts(base::flat_set<CertProfileId> cert_profile_ids_to_keep,
+                   CertDeleterCallback callback);
+
+ private:
+  void ProcessOneCert(scoped_refptr<net::X509Certificate> cert,
+                      const CertProfileId& cert_profile_id,
+                      const std::string& error_message);
+  void RememberOrDelete(scoped_refptr<net::X509Certificate> new_cert,
+                        const CertProfileId& cert_profile_id);
+  void DeleteCert(scoped_refptr<net::X509Certificate> cert);
+  void OnDeleteCertDone(const std::string& error_message);
+  void OnIterationFinished(const std::string& error_message);
+  void CheckStateAndMaybeFinish();
+  void ReturnStatus(const std::string& error_message);
+
+  const CertScope cert_scope_ = CertScope::kDevice;
+  platform_keys::PlatformKeysService* const platform_keys_service_ = nullptr;
+
+  CertIterator iterator_;
+  bool iteration_finished_ = false;
+  size_t pending_delete_tasks_counter_ = 0;
+  CertDeleterCallback callback_;
+
+  // Contains list of currently existing certificate profile ids. Certificates
+  // with ids outside of this set can be deleted.
   base::flat_set<CertProfileId> cert_profile_ids_to_keep_;
-  DeleteCertsCallback callback_;
 
-  std::unique_ptr<CertProvisioningCertsWithIdsGetter> cert_getter_;
+  // Stores previously seen certificates that allows to find duplicates.
+  base::flat_map<CertProfileId, scoped_refptr<net::X509Certificate>>
+      certs_with_ids_;
 
   SEQUENCE_CHECKER(sequence_checker_);
-  base::WeakPtrFactory<CertProvisioningCertDeleter> weak_factory_{this};
+  base::WeakPtrFactory<CertDeleter> weak_factory_{this};
 };
 
 }  // namespace cert_provisioning

chrome/browser/chromeos/cert_provisioning/cert_provisioning_scheduler.cc

@@ -15,6 +15,7 @@
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/optional.h"
+#include "base/stl_util.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_process_platform_part.h"
@@ -103,6 +104,8 @@ CertProvisioningScheduler::CreateUserCertProvisioningScheduler(
   PrefService* pref_service = profile->GetPrefs();
   policy::CloudPolicyClient* cloud_policy_client =
       GetCloudPolicyClientForUser(profile);
+  platform_keys::PlatformKeysService* platform_keys_service =
+      platform_keys::PlatformKeysServiceFactory::GetForBrowserContext(profile);
   NetworkStateHandler* network_state_handler = GetNetworkStateHandler();
 
   if (!profile || !pref_service || !cloud_policy_client ||
@@ -112,9 +115,8 @@ CertProvisioningScheduler::CreateUserCertProvisioningScheduler(
   }
 
   return std::make_unique<CertProvisioningScheduler>(
-      CertScope::kUser, profile, pref_service,
-      prefs::kRequiredClientCertificateForUser, cloud_policy_client,
-      network_state_handler,
+      CertScope::kUser, profile, pref_service, cloud_policy_client,
+      platform_keys_service, network_state_handler,
       std::make_unique<CertProvisioningUserInvalidatorFactory>(profile));
 }
 
@@ -127,18 +129,19 @@ CertProvisioningScheduler::CreateDeviceCertProvisioningScheduler(
   PrefService* pref_service = g_browser_process->local_state();
   policy::CloudPolicyClient* cloud_policy_client =
       GetCloudPolicyClientForDevice();
+  platform_keys::PlatformKeysService* platform_keys_service =
+      platform_keys::PlatformKeysServiceFactory::GetForBrowserContext(profile);
   NetworkStateHandler* network_state_handler = GetNetworkStateHandler();
 
   if (!profile || !pref_service || !cloud_policy_client ||
-      !network_state_handler) {
+      !network_state_handler || !platform_keys_service) {
     LOG(ERROR) << "Failed to create device certificate provisioning scheduler";
     return nullptr;
   }
 
   return std::make_unique<CertProvisioningScheduler>(
-      CertScope::kDevice, profile, pref_service,
-      prefs::kRequiredClientCertificateForDevice, cloud_policy_client,
-      network_state_handler,
+      CertScope::kDevice, profile, pref_service, cloud_policy_client,
+      platform_keys_service, network_state_handler,
       std::make_unique<CertProvisioningDeviceInvalidatorFactory>(
           invalidation_service_provider));
 }
@@ -147,26 +150,28 @@ CertProvisioningScheduler::CertProvisioningScheduler(
     CertScope cert_scope,
     Profile* profile,
     PrefService* pref_service,
-    const char* pref_name,
     policy::CloudPolicyClient* cloud_policy_client,
+    platform_keys::PlatformKeysService* platform_keys_service,
     NetworkStateHandler* network_state_handler,
     std::unique_ptr<CertProvisioningInvalidatorFactory> invalidator_factory)
     : cert_scope_(cert_scope),
       profile_(profile),
       pref_service_(pref_service),
-      pref_name_(pref_name),
       cloud_policy_client_(cloud_policy_client),
+      platform_keys_service_(platform_keys_service),
       network_state_handler_(network_state_handler),
+      certs_with_ids_getter_(cert_scope, platform_keys_service),
+      cert_deleter_(cert_scope, platform_keys_service),
       invalidator_factory_(std::move(invalidator_factory)) {
+  CHECK(profile);
   CHECK(pref_service_);
-  CHECK(pref_name_);
   CHECK(cloud_policy_client_);
-  CHECK(profile);
+  CHECK(platform_keys_service_);
+  CHECK(network_state_handler);
   CHECK(invalidator_factory_);
 
-  platform_keys_service_ =
-      platform_keys::PlatformKeysServiceFactory::GetForBrowserContext(profile);
-  CHECK(platform_keys_service_);
+  pref_name_ = GetPrefNameForCertProfiles(cert_scope);
+  CHECK(pref_name_);
 
   network_state_handler_->AddObserver(this, FROM_HERE);
 
@@ -198,16 +203,31 @@ void CertProvisioningScheduler::ScheduleDailyUpdate() {
       base::TimeDelta::FromDays(1));
 }
 
-void CertProvisioningScheduler::ScheduleRetry(const CertProfile& profile) {
+void CertProvisioningScheduler::ScheduleRetry(const CertProfileId& profile_id) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   base::SequencedTaskRunnerHandle::Get()->PostDelayedTask(
       FROM_HERE,
       base::Bind(&CertProvisioningScheduler::UpdateOneCertImpl,
-                 weak_factory_.GetWeakPtr(), profile.profile_id),
+                 weak_factory_.GetWeakPtr(), profile_id),
       kInconsistentDataErrorRetryDelay);
 }
 
+void CertProvisioningScheduler::ScheduleRenewal(const CertProfileId& profile_id,
+                                                base::TimeDelta delay) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (base::Contains(scheduled_renewals_, profile_id)) {
+    return;
+  }
+
+  base::SequencedTaskRunnerHandle::Get()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&CertProvisioningScheduler::InitiateRenewal,
+                 weak_factory_.GetWeakPtr(), profile_id),
+      delay);
+}
+
 void CertProvisioningScheduler::InitialUpdateCerts() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
@@ -227,9 +247,8 @@ void CertProvisioningScheduler::DeleteCertsWithoutPolicy() {
     cert_profile_ids_to_keep = base::flat_set<CertProfileId>(std::move(ids));
   }
 
-  cert_deleter_ = std::make_unique<CertProvisioningCertDeleter>();
-  cert_deleter_->DeleteCerts(
-      cert_scope_, platform_keys_service_, cert_profile_ids_to_keep,
+  cert_deleter_.DeleteCerts(
+      cert_profile_ids_to_keep,
       base::BindOnce(&CertProvisioningScheduler::OnDeleteCertsWithoutPolicyDone,
                      weak_factory_.GetWeakPtr()));
 }
@@ -238,15 +257,12 @@ void CertProvisioningScheduler::OnDeleteCertsWithoutPolicyDone(
     const std::string& error_message) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  cert_deleter_.reset();
-
   if (!error_message.empty()) {
     LOG(ERROR) << "Failed to delete certificates without policies: "
                << error_message;
   }
 
   DeserializeWorkers();
-
   CleanVaKeysIfIdle();
 }
 
@@ -326,6 +342,12 @@ void CertProvisioningScheduler::OnPrefsChange() {
   UpdateAllCerts();
 }
 
+void CertProvisioningScheduler::InitiateRenewal(
+    const CertProfileId& cert_profile_id) {
+  scheduled_renewals_.erase(cert_profile_id);
+  UpdateOneCertImpl(cert_profile_id);
+}
+
 void CertProvisioningScheduler::UpdateOneCert(
     const CertProfileId& cert_profile_id) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -336,6 +358,8 @@ void CertProvisioningScheduler::UpdateOneCert(
 
 void CertProvisioningScheduler::UpdateOneCertImpl(
     const CertProfileId& cert_profile_id) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
   EraseByKey(failed_cert_profiles_, cert_profile_id);
 
   base::Optional<CertProfile> cert_profile = GetOneCertProfile(cert_profile_id);
@@ -351,6 +375,11 @@ void CertProvisioningScheduler::UpdateAllCerts() {
 
   std::vector<CertProfile> profiles = GetCertProfiles();
   CancelWorkersWithoutPolicy(profiles);
+
+  if (profiles.empty()) {
+    return;
+  }
+
   UpdateCertList(std::move(profiles));
 }
 
@@ -362,19 +391,15 @@ void CertProvisioningScheduler::UpdateCertList(
     return;
   }
 
-  if (certs_with_ids_getter_ && certs_with_ids_getter_->IsRunning()) {
+  if (certs_with_ids_getter_.IsRunning()) {
     queued_profiles_to_update_.insert(std::make_move_iterator(profiles.begin()),
                                       std::make_move_iterator(profiles.end()));
     return;
   }
 
-  certs_with_ids_getter_ =
-      std::make_unique<CertProvisioningCertsWithIdsGetter>();
-  certs_with_ids_getter_->GetCertsWithIds(
-      cert_scope_, platform_keys_service_,
-      base::BindOnce(
-          &CertProvisioningScheduler::UpdateCertListWithExistingCerts,
-          weak_factory_.GetWeakPtr(), std::move(profiles)));
+  certs_with_ids_getter_.GetCertsWithIds(base::BindOnce(
+      &CertProvisioningScheduler::UpdateCertListWithExistingCerts,
+      weak_factory_.GetWeakPtr(), std::move(profiles)));
 }
 
 void CertProvisioningScheduler::UpdateCertListWithExistingCerts(
@@ -384,20 +409,38 @@ void CertProvisioningScheduler::UpdateCertListWithExistingCerts(
     const std::string& error_message) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  certs_with_ids_getter_.reset();
-
   if (!error_message.empty()) {
     LOG(ERROR) << "Failed to get existing cert ids: " << error_message;
     return;
   }
 
   for (const auto& profile : profiles) {
-    if (base::Contains(existing_certs_with_ids, profile.profile_id) ||
-        base::Contains(failed_cert_profiles_, profile.profile_id)) {
+    if (base::Contains(failed_cert_profiles_, profile.profile_id)) {
+      continue;
+    }
+
+    auto cert_iter = existing_certs_with_ids.find(profile.profile_id);
+    if (cert_iter == existing_certs_with_ids.end()) {
+      // The certificate does not exists and should be provisioned.
+      ProcessProfile(profile);
       continue;
     }
 
-    ProcessProfile(profile);
+    const auto& cert = cert_iter->second;
+    base::Time now = base::Time::Now();
+    if ((now + profile.renewal_period) >= cert->valid_expiry()) {
+      // The certificate should be renewed immediately.
+      ProcessProfile(profile);
+      continue;
+    }
+
+    if ((now + base::TimeDelta::FromDays(1) + profile.renewal_period) >=
+        cert->valid_expiry()) {
+      // The certificate should be renewed within 1 day.
+      base::Time target_time = cert->valid_expiry() - profile.renewal_period;
+      ScheduleRenewal(profile.profile_id, /*delay=*/target_time - now);
+      continue;
+    }
   }
 
   if (!queued_profiles_to_update_.empty()) {
@@ -470,7 +513,7 @@ void CertProvisioningScheduler::OnProfileFinished(
     case CertProvisioningWorkerState::kInconsistentDataError:
       LOG(WARNING) << "Inconsistent data error for certificate profile: "
                    << profile.profile_id;
-      ScheduleRetry(profile);
+      ScheduleRetry(profile.profile_id);
       break;
     case CertProvisioningWorkerState::kCanceled:
       break;

chrome/browser/chromeos/cert_provisioning/cert_provisioning_scheduler.h

@@ -75,8 +75,8 @@ class CertProvisioningScheduler : public NetworkStateHandlerObserver {
       CertScope cert_scope,
       Profile* profile,
       PrefService* pref_service,
-      const char* pref_name,
       policy::CloudPolicyClient* cloud_policy_client,
+      platform_keys::PlatformKeysService* platform_keys_service,
       NetworkStateHandler* network_state_handler,
       std::unique_ptr<CertProvisioningInvalidatorFactory> invalidator_factory);
   ~CertProvisioningScheduler() override;
@@ -99,8 +99,9 @@ class CertProvisioningScheduler : public NetworkStateHandlerObserver {
  private:
   void ScheduleInitialUpdate();
   void ScheduleDailyUpdate();
-  // Posts delayed task to call ProcessProfile.
-  void ScheduleRetry(const CertProfile& profile);
+  // Posts delayed task to call UpdateOneCertImpl.
+  void ScheduleRetry(const CertProfileId& profile_id);
+  void ScheduleRenewal(const CertProfileId& profile_id, base::TimeDelta delay);
 
   void InitialUpdateCerts();
   void DeleteCertsWithoutPolicy();
@@ -110,6 +111,7 @@ class CertProvisioningScheduler : public NetworkStateHandlerObserver {
   void OnCleanVaKeysIfIdleDone(base::Optional<bool> delete_result);
   void RegisterForPrefsChanges();
 
+  void InitiateRenewal(const CertProfileId& cert_profile_id);
   void UpdateOneCertImpl(const CertProfileId& cert_profile_id);
   void UpdateCertList(std::vector<CertProfile> profiles);
   void UpdateCertListWithExistingCerts(
@@ -150,10 +152,14 @@ class CertProvisioningScheduler : public NetworkStateHandlerObserver {
   PrefService* pref_service_ = nullptr;
   const char* pref_name_ = nullptr;
   policy::CloudPolicyClient* cloud_policy_client_ = nullptr;
-  NetworkStateHandler* network_state_handler_ = nullptr;
   platform_keys::PlatformKeysService* platform_keys_service_ = nullptr;
+  NetworkStateHandler* network_state_handler_ = nullptr;
   PrefChangeRegistrar pref_change_registrar_;
   WorkerMap workers_;
+  // Contains cert profile ids that will be renewed before next daily update.
+  // Helps to prevent creation of more than one delayed task for renewal. When
+  // the renewal starts for a profile id, it is removed from the set.
+  base::flat_set<CertProfileId> scheduled_renewals_;
   // Collection of cert profile ids that failed recently. They will not be
   // retried until next |DailyUpdateCerts|. FailedWorkerInfo contains some extra
   // information about the failure. Profiles that failed with
@@ -167,8 +173,8 @@ class CertProvisioningScheduler : public NetworkStateHandlerObserver {
   // run, because an update for them was triggered during the current run.
   CertProfileSet queued_profiles_to_update_;
 
-  std::unique_ptr<CertProvisioningCertsWithIdsGetter> certs_with_ids_getter_;
-  std::unique_ptr<CertProvisioningCertDeleter> cert_deleter_;
+  LatestCertsWithIdsGetter certs_with_ids_getter_;
+  CertDeleter cert_deleter_;
   std::unique_ptr<CertProvisioningInvalidatorFactory> invalidator_factory_;
 
   base::WeakPtrFactory<CertProvisioningScheduler> weak_factory_{this};

chrome/browser/chromeos/cert_provisioning/cert_provisioning_serializer.cc

@@ -7,6 +7,7 @@
 #include "base/base64.h"
 #include "base/logging.h"
 #include "base/optional.h"
+#include "base/time/time.h"
 #include "chrome/browser/chromeos/cert_provisioning/cert_provisioning_common.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
@@ -16,15 +17,16 @@ namespace cert_provisioning {
 
 namespace {
 
-const char kKeyNameCertScope[] = "cert_scope";
-const char kKeyNameCertProfile[] = "cert_profile";
-const char kKeyNameState[] = "state";
-const char kKeyNamePublicKey[] = "public_key";
-const char kKeyNameInvalidationTopic[] = "invalidation_topic";
+constexpr char kKeyNameCertScope[] = "cert_scope";
+constexpr char kKeyNameCertProfile[] = "cert_profile";
+constexpr char kKeyNameState[] = "state";
+constexpr char kKeyNamePublicKey[] = "public_key";
+constexpr char kKeyNameInvalidationTopic[] = "invalidation_topic";
 
-const char kKeyNameCertProfileId[] = "profile_id";
-const char kKeyNameCertProfileVersion[] = "policy_version";
-const char kKeyNameCertProfileVaEnabled[] = "va_enabled";
+constexpr char kKeyNameCertProfileId[] = "profile_id";
+constexpr char kKeyNameCertProfileVersion[] = "policy_version";
+constexpr char kKeyNameCertProfileVaEnabled[] = "va_enabled";
+constexpr char kKeyNameCertProfileRenewalPeriod[] = "renewal_period";
 
 template <typename T>
 bool ConvertToEnum(int value, T* dst) {
@@ -71,21 +73,34 @@ bool DeserializeBoolValue(const base::Value& parent_value,
   return true;
 }
 
+bool DeserializeRenewalPeriod(const base::Value& parent_value,
+                              const char* value_name,
+                              base::TimeDelta* dst) {
+  base::Optional<int> serialized_time = parent_value.FindIntKey(value_name);
+  *dst = base::TimeDelta::FromSeconds(serialized_time.value_or(0));
+  return true;
+}
+
 base::Value SerializeCertProfile(const CertProfile& profile) {
-  static_assert(CertProfile::kVersion == 3, "This function should be updated");
+  static_assert(CertProfile::kVersion == 4, "This function should be updated");
 
   base::Value result(base::Value::Type::DICTIONARY);
   result.SetStringKey(kKeyNameCertProfileId, profile.profile_id);
   result.SetStringKey(kKeyNameCertProfileVersion, profile.policy_version);
   result.SetBoolKey(kKeyNameCertProfileVaEnabled, profile.is_va_enabled);
 
+  if (!profile.renewal_period.is_zero()) {
+    result.SetIntKey(kKeyNameCertProfileRenewalPeriod,
+                     profile.renewal_period.InSeconds());
+  }
+
   return result;
 }
 
 bool DeserializeCertProfile(const base::Value& parent_value,
                             const char* value_name,
                             CertProfile* dst) {
-  static_assert(CertProfile::kVersion == 3, "This function should be updated");
+  static_assert(CertProfile::kVersion == 4, "This function should be updated");
 
   const base::Value* serialized_profile =
       parent_value.FindKeyOfType(value_name, base::Value::Type::DICTIONARY);
@@ -104,6 +119,9 @@ bool DeserializeCertProfile(const base::Value& parent_value,
   is_ok = is_ok && DeserializeBoolValue(*serialized_profile,
                                         kKeyNameCertProfileVaEnabled,
                                         &(dst->is_va_enabled));
+  is_ok = is_ok && DeserializeRenewalPeriod(*serialized_profile,
+                                            kKeyNameCertProfileRenewalPeriod,
+                                            &(dst->renewal_period));
   return is_ok;
 }
 

chrome/browser/chromeos/cert_provisioning/cert_provisioning_test_helpers.cc

@@ -6,7 +6,7 @@
 
 #include "base/optional.h"
 #include "base/test/gmock_callback_support.h"
-#include "chrome/browser/chromeos/platform_keys/platform_keys_service.h"
+#include "base/time/time.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "net/test/cert_builder.h"
@@ -63,18 +63,15 @@ void CertificateHelperForTesting::GetCertificates(
   std::move(callback).Run(std::move(result), "");
 }
 
-void CertificateHelperForTesting::AddCert(
-    CertScope cert_scope,
-    const base::Optional<CertProfileId>& cert_profile_id) {
-  AddCert(cert_scope, cert_profile_id, /*error_message=*/"");
-}
-
-void CertificateHelperForTesting::AddCert(
+scoped_refptr<net::X509Certificate> CertificateHelperForTesting::AddCert(
     CertScope cert_scope,
     const base::Optional<CertProfileId>& cert_profile_id,
-    const std::string& error_message) {
+    const std::string& error_message,
+    base::Time not_valid_before,
+    base::Time not_valid_after) {
   net::CertBuilder cert_builder(template_cert_->cert_buffer(),
                                 /*issuer=*/nullptr);
+  cert_builder.SetValidity(not_valid_before, not_valid_after);
   auto cert = cert_builder.GetX509Certificate();
 
   EXPECT_CALL(
@@ -86,6 +83,30 @@ void CertificateHelperForTesting::AddCert(
       .WillRepeatedly(RunOnceCallback<3>(cert_profile_id, error_message));
 
   cert_list_.push_back(cert);
+  return cert;
+}
+
+scoped_refptr<net::X509Certificate> CertificateHelperForTesting::AddCert(
+    CertScope cert_scope,
+    const base::Optional<CertProfileId>& cert_profile_id) {
+  base::Time not_valid_before =
+      base::Time::Now() - base::TimeDelta::FromDays(1);
+  base::Time not_valid_after =
+      base::Time::Now() + base::TimeDelta::FromDays(365);
+  return AddCert(cert_scope, cert_profile_id, /*error_message=*/"",
+                 not_valid_before, not_valid_after);
+}
+
+scoped_refptr<net::X509Certificate> CertificateHelperForTesting::AddCert(
+    CertScope cert_scope,
+    const base::Optional<CertProfileId>& cert_profile_id,
+    const std::string& error_message) {
+  base::Time not_valid_before =
+      base::Time::Now() - base::TimeDelta::FromDays(1);
+  base::Time not_valid_after =
+      base::Time::Now() + base::TimeDelta::FromDays(365);
+  return AddCert(cert_scope, cert_profile_id, error_message, not_valid_before,
+                 not_valid_after);
 }
 
 void CertificateHelperForTesting::ClearCerts() {

chrome/browser/chromeos/cert_provisioning/cert_provisioning_test_helpers.h

@@ -19,19 +19,41 @@ namespace cert_provisioning {
 
 //================ CertificateHelperForTesting =================================
 
-// Redirects PlatformKeysService::GetCertificate calls to itself. Allows to add
-// certificate to a fake storage with assigned CertProfileId-s.
+// Allows to add certificate to a fake storage with assigned CertProfileId-s.
+// Redirects PlatformKeysService::GetCertificate calls to itself and return all
+// stored certificates as a result.
 struct CertificateHelperForTesting {
  public:
   explicit CertificateHelperForTesting(
       platform_keys::MockPlatformKeysService* platform_keys_service);
   ~CertificateHelperForTesting();
 
-  void AddCert(CertScope cert_scope,
-               const base::Optional<CertProfileId>& cert_profile_id);
-  void AddCert(CertScope cert_scope,
-               const base::Optional<CertProfileId>& cert_profile_id,
-               const std::string& error_message);
+  // Generates and adds a certificate to internal fake certificate storage.
+  // Returns refpointer to the generated certificate. If |error_message| is not
+  // empty, an attempt to retrieve |cert_profile_id| via
+  // PlatformKeysService::GetAttributeForKey() will fail with |error_message|.
+  // |not_valid_before|, |not_valid_after| configure validity period of the
+  // certificate.
+  scoped_refptr<net::X509Certificate> AddCert(
+      CertScope cert_scope,
+      const base::Optional<CertProfileId>& cert_profile_id,
+      const std::string& error_message,
+      base::Time not_valid_before,
+      base::Time not_valid_after);
+
+  // Simplified version of AddCert(). The certificate is not expired and has
+  // |cert_profile_id|.
+  scoped_refptr<net::X509Certificate> AddCert(
+      CertScope cert_scope,
+      const base::Optional<CertProfileId>& cert_profile_id);
+
+  // Simplified version of AddCert(). The certificate is not expired, but fails
+  // to retrieve |cert_profile_id|.
+  scoped_refptr<net::X509Certificate> AddCert(
+      CertScope cert_scope,
+      const base::Optional<CertProfileId>& cert_profile_id,
+      const std::string& error_message);
+
   void ClearCerts();
   const net::CertificateList& GetCerts() const;
 

chrome/browser/chromeos/cert_provisioning/cert_provisioning_worker.cc

@@ -109,19 +109,6 @@ int GetStateOrderedIndex(CertProvisioningWorkerState state) {
   return res;
 }
 
-bool CheckPublicKeyInCertificate(
-    const scoped_refptr<net::X509Certificate>& cert,
-    const std::string& public_key) {
-  base::StringPiece spki_from_cert;
-  if (!net::asn1::ExtractSPKIFromDERCert(
-          net::x509_util::CryptoBufferAsStringPiece(cert->cert_buffer()),
-          &spki_from_cert)) {
-    return false;
-  }
-
-  return (public_key == spki_from_cert);
-}
-
 }  // namespace
 
 // ============= CertProvisioningWorkerFactory =================================
@@ -633,7 +620,9 @@ void CertProvisioningWorkerImpl::ImportCert(
     return;
   }
 
-  if (!CheckPublicKeyInCertificate(cert, public_key_)) {
+  std::string public_key_from_cert =
+      platform_keys::GetSubjectPublicKeyInfo(cert);
+  if (public_key_from_cert != public_key_) {
     LOG(ERROR) << "Downloaded certificate does not match the expected key pair";
     UpdateState(CertProvisioningWorkerState::kFailed);
     return;