Commit dbe15ebf authored by Filip Gorski's avatar Filip Gorski Committed by Commit Bot

[Sheriff] Disabling failing LocationBarModel tests

Choosing to disable 3 tests failing on an assert, because an alternative
is to revert a crash fix. This fails on assert which is compiled out.

TBR=peconn@chromium.org

Bug: 1128073
Change-Id: Icc5667f4ad1504c7776bc06af010e9f8d94b5a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410923Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806778}
parent 395c0fb9
...@@ -19,6 +19,7 @@ import org.junit.runner.RunWith; ...@@ -19,6 +19,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeTabbedActivity; import org.chromium.chrome.browser.ChromeTabbedActivity;
...@@ -102,6 +103,7 @@ public class LocationBarModelTest { ...@@ -102,6 +103,7 @@ public class LocationBarModelTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug/1128073")
public void testGetProfileOnNullTabInIncognito() { public void testGetProfileOnNullTabInIncognito() {
mActivityTestRule.startMainActivityOnBlankPage(); mActivityTestRule.startMainActivityOnBlankPage();
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
...@@ -114,6 +116,7 @@ public class LocationBarModelTest { ...@@ -114,6 +116,7 @@ public class LocationBarModelTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug/1128073")
public void testGetProfileOnMockTabInIncognito() { public void testGetProfileOnMockTabInIncognito() {
mActivityTestRule.startMainActivityOnBlankPage(); mActivityTestRule.startMainActivityOnBlankPage();
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
...@@ -149,6 +152,7 @@ public class LocationBarModelTest { ...@@ -149,6 +152,7 @@ public class LocationBarModelTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug/1128073")
public void testGetProfileOnMockTabInRegularCCT() { public void testGetProfileOnMockTabInRegularCCT() {
// Create an launch a regular CCT. // Create an launch a regular CCT.
Intent intent = CustomTabsTestUtils.createMinimalCustomTabIntent( Intent intent = CustomTabsTestUtils.createMinimalCustomTabIntent(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment