WebUI Polymer 2 migration: Fix PDFViewer tests.

Tests affected:
PDFExtensionTest.Basic
PDFExtensionTest.Bookmark
PDFExtensionTest.Elements
PDFExtensionTest.ToolbarManager

Most of the fixes involve adding Custom Elements to be tested in the document,
otherwise their local DOM is not populated (unlike Polymer 1).

Bug: 849476
Change-Id: Id953179142174cb5922bf53bcaa139011ea76ca9
Reviewed-on: https://chromium-review.googlesource.com/1100304Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567312}

chrome/test/data/pdf/basic_test.js

@@ -4,8 +4,8 @@
 
 var tests = [
   /**
-   * Test that some key elements exist and that they have the appropriate
-   * constructor name. This verifies that polymer is working correctly.
+   * Test that some key elements exist and that they have a shadowRoot. This
+   * verifies that Polymer is working correctly.
    */
   function testHasElements() {
     var elementNames = [
@@ -15,11 +15,9 @@ var tests = [
       'viewer-error-screen'
     ];
     for (var i = 0; i < elementNames.length; i++) {
-      var elements = document.querySelectorAll(elementNames[i]);
+      var elements = document.body.querySelectorAll(elementNames[i]);
       chrome.test.assertEq(1, elements.length);
-      var element = elements[0];
-      chrome.test.assertTrue(
-          String(element.constructor).indexOf(elementNames[i]) != -1);
+      chrome.test.assertTrue(elements[0].shadowRoot !== null);
     }
     chrome.test.succeed();
   },

chrome/test/data/pdf/bookmarks_test.js

@@ -55,6 +55,7 @@ var tests = [
       bookmarks: viewer.bookmarks,
       depth: 1
     });
+    document.body.appendChild(bookmarkContent);
 
     Polymer.dom.flush();
 

chrome/test/data/pdf/material_elements_test.js

@@ -37,6 +37,7 @@ var tests = [
   function testPageSelectorChange() {
     var selector =
         Polymer.Base.create('viewer-page-selector', {docLength: 1234});
+    document.body.appendChild(selector);
 
     var input = selector.$.input;
     // Simulate entering text into `input` and pressing enter.
@@ -75,6 +76,7 @@ var tests = [
   function testPageSelectorDocLength() {
     var selector =
         Polymer.Base.create('viewer-page-selector', {docLength: 1234});
+    document.body.appendChild(selector);
     chrome.test.assertEq('1234', selector.$.pagelength.textContent);
     chrome.test.assertEq('4ch', selector.$.pageselector.style.width);
     chrome.test.succeed();
@@ -89,6 +91,7 @@ var tests = [
       closedIcon: 'closedIcon',
       openIcon: 'openIcon'
     });
+    document.body.appendChild(dropdown);
 
     chrome.test.assertFalse(dropdown.dropdownOpen);
     chrome.test.assertEq('closedIcon', dropdown.dropdownIcon);
@@ -127,6 +130,7 @@ var tests = [
       }],
       depth: 1
     });
+    document.body.appendChild(bookmarkContent);
 
     // Force templates to render.
     Polymer.dom.flush();
@@ -164,7 +168,8 @@ var tests = [
    * fit-to-width buttons.
    */
   function testZoomToolbarToggle() {
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar', {});
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var fitButton = zoomToolbar.$['fit-button'];
     var fab = fitButton.$['button'];
 
@@ -214,7 +219,8 @@ var tests = [
   },
 
   function testZoomToolbarForceFitToPage() {
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar', {});
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var fitButton = zoomToolbar.$['fit-button'];
     var fab = fitButton.$['button'];
 
@@ -255,7 +261,8 @@ var tests = [
   },
 
   function testZoomToolbarForceFitToWidth() {
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar', {});
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var fitButton = zoomToolbar.$['fit-button'];
     var fab = fitButton.$['button'];
 

chrome/test/data/pdf/toolbar_manager_test.js

@@ -52,8 +52,10 @@ var tests = [
   function testToolbarManagerForceHideTopToolbar() {
     var mockWindow = new MockWindow(1920, 1080);
 
-    var toolbar = Polymer.Base.create('viewer-pdf-toolbar');
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar');
+    var toolbar = document.createElement('viewer-pdf-toolbar');
+    document.body.appendChild(toolbar);
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var toolbarManager = new ToolbarManager(mockWindow, toolbar, zoomToolbar);
     toolbarManager.getCurrentTimestamp_ = mockGetCurrentTimestamp;
 
@@ -122,7 +124,9 @@ var tests = [
     var mockWindow = new MockWindow(1920, 1080);
     var toolbar =
         Polymer.Base.create('viewer-pdf-toolbar', {loadProgress: 100});
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar');
+    document.body.appendChild(toolbar);
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var toolbarManager = new ToolbarManager(mockWindow, toolbar, zoomToolbar);
     toolbarManager.getCurrentTimestamp_ = mockGetCurrentTimestamp;
 
@@ -162,7 +166,9 @@ var tests = [
     var mockWindow = new MockWindow(1920, 1080);
     var toolbar =
         Polymer.Base.create('viewer-pdf-toolbar', {loadProgress: 100});
-    var zoomToolbar = Polymer.Base.create('viewer-zoom-toolbar');
+    document.body.appendChild(toolbar);
+    var zoomToolbar = document.createElement('viewer-zoom-toolbar');
+    document.body.appendChild(zoomToolbar);
     var toolbarManager = new ToolbarManager(mockWindow, toolbar, zoomToolbar);
 
     toolbarManager.hideToolbarsIfAllowed();