Revert "Relax NV12 format rejection for exo"

This reverts commit 5142981c.

Reason for revert: Causing crashes on Octopus (kernel 4.14) media plays b/141202973
Bug: b/141202973

Original change's description:
> Relax NV12 format rejection for exo
> 
> Applies the same restriction in other scenarios (web page/apps).
> 
> * Reject iff
>  - the buffer is cropped hirozontally, and
>  - the cropped bounds' horizontal coordinates (x and width) doesn't
>    fall into even pixel boundary
> 
> Bug: 997821
> Test: manually tested with netflix web/arc apps on eve.
> Change-Id: I10ea54da345427eb33fbee25c8d872363d08b0a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775190
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692771}

TBR=oshima@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 997821
Change-Id: I4633f6aac96505fbc1c173a65bc1b4d7a79b9726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838896Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702832}

components/exo/display.cc

@@ -111,14 +111,22 @@ std::unique_ptr<Buffer> Display::CreateLinuxDMABufBuffer(
   // Using zero-copy for optimal performance.
   bool use_zero_copy = true;
 
+#if defined(ARCH_CPU_X86_FAMILY)
+  // TODO(dcastagna): Re-enable NV12 format as HW overlay once b/113362843
+  // is addressed.
+  bool is_overlay_candidate = format != gfx::BufferFormat::YUV_420_BIPLANAR;
+#else
+  bool is_overlay_candidate = true;
+#endif
+
   return std::make_unique<Buffer>(
       std::move(gpu_memory_buffer),
       gpu::NativeBufferNeedsPlatformSpecificTextureTarget(format)
           ? gpu::GetPlatformSpecificTextureTarget()
           : GL_TEXTURE_2D,
       // COMMANDS_COMPLETED queries are required by native pixmaps.
-      GL_COMMANDS_COMPLETED_CHROMIUM, use_zero_copy,
-      /*is_overlay_candidate=*/true, y_invert);
+      GL_COMMANDS_COMPLETED_CHROMIUM, use_zero_copy, is_overlay_candidate,
+      y_invert);
 }
 #endif  // defined(USE_OZONE)
 

ui/ozone/platform/drm/common/drm_overlay_manager.cc

@@ -9,7 +9,6 @@
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
-#include "build/build_config.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/ozone/platform/drm/common/drm_overlay_candidates.h"
 #include "ui/ozone/public/overlay_surface_candidate.h"
@@ -126,21 +125,6 @@ bool DrmOverlayManager::CanHandleCandidate(
     return false;
   }
 
-#if defined(ARCH_CPU_X86_FAMILY)
-  // TODO(dcastagna|oshima): Re-enable NV12 format as HW overlay once
-  // b/113362843 is addressed.
-  if (candidate.format == gfx::BufferFormat::YUV_420_BIPLANAR) {
-    // Reject buffer whose cropped horizontal coordinates doesn't fall on
-    // even pixel boundary.
-    int nearest_x = gfx::ToRoundedInt(candidate.buffer_size.width() *
-                                      candidate.crop_rect.x());
-    int nearest_width = gfx::ToRoundedInt(candidate.buffer_size.width() *
-                                          candidate.crop_rect.width());
-    if (nearest_x % 2 != 0 || nearest_width % 2 != 0)
-      return false;
-  }
-#endif
-
   return true;
 }