Change Help page title to About.

The Help page (chrome://help) should be called "About". This changes the page title and header, and the link in the uber frame sidebar. BUG=381794 R=dbeam@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/316343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275643 0039d316-1c4b-4281-b951-d872f2087c98

Change Help page title to About.
The Help page (chrome://help) should be called "About". This changes the page title and header, and the link in the uber frame sidebar. BUG=381794 R=dbeam@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/316343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275643 0039d316-1c4b-4281-b951-d872f2087c98
dbffc7a7 · michaelpg@chromium.org · 9f5fc7bb · dbffc7a7 · dbffc7a7 · dbffc7a7
Commit dbffc7a7 authored Jun 07, 2014 by michaelpg@chromium.org
6 changed files
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -9467,9 +9467,6 @@ Chrome ran out of memory.

      <!-- chrome://help -->
      <if expr="not is_android">
-        <message name="IDS_HELP_TITLE" desc="Label used for title of the help page.">
-          Help
-        </message>
        <if expr="chromeos">
          <message name="IDS_SHOW_MORE_INFO" desc="The label of the 'More info' link.">
            More info...
@@ -9479,8 +9476,7 @@ Chrome ran out of memory.
          </message>
        </if>

-        <!-- The About page is now part of options. -->
-        <message name="IDS_ABOUT_TAB_TITLE" desc="Label used for tab of about page.">
+        <message name="IDS_ABOUT_TITLE" desc="Label used for title of the About page, chrome://help.">
          About
        </message>
        <if expr="not chromeos and use_titlecase">

--- a/chrome/browser/resources/help/help.html
+++ b/chrome/browser/resources/help/help.html
@@ -2,7 +2,7 @@
 <html i18n-values="dir:textdirection;">
 <head>
  <meta charset="utf-8">
-  <title i18n-content="helpTitle"></title>
+  <title i18n-content="aboutTitle"></title>
  <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
  <link rel="stylesheet" href="../uber/uber_shared.css">
  <link rel="stylesheet" href="help.css">

--- a/chrome/browser/resources/help/help.js
+++ b/chrome/browser/resources/help/help.js
@@ -56,7 +56,7 @@ cr.define('help', function() {
      uber.onContentFrameLoaded();

      // Set the title.
-      uber.setTitle(loadTimeData.getString('helpTitle'));
+      uber.setTitle(loadTimeData.getString('aboutTitle'));

      $('product-license').innerHTML = loadTimeData.getString('productLicense');
      if (cr.isChromeOS) {

--- a/chrome/browser/ui/toolbar/origin_chip_info.cc
+++ b/chrome/browser/ui/toolbar/origin_chip_info.cc
@@ -59,7 +59,7 @@ int StringForChromeHost(const GURL& url) {
  if (host == chrome::kChromeUIExtensionsHost)
    return IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE;
  if (host == chrome::kChromeUIHelpHost)
-    return IDS_ABOUT_TAB_TITLE;
+    return IDS_ABOUT_TITLE;
  if (host == chrome::kChromeUIHistoryHost)
    return IDS_HISTORY_TITLE;
  if (host == chrome::kChromeUINewTabHost)

--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -149,8 +149,7 @@ void HelpHandler::GetLocalizedValues(content::WebUIDataSource* source) {
  };

  static L10nResources resources[] = {
-    { "helpTitle", IDS_HELP_TITLE },
-    { "aboutTitle", IDS_ABOUT_TAB_TITLE },
+    { "aboutTitle", IDS_ABOUT_TITLE },
 #if defined(OS_CHROMEOS)
    { "aboutProductTitle", IDS_PRODUCT_OS_NAME },
 #else

--- a/chrome/browser/ui/webui/uber/uber_ui.cc
+++ b/chrome/browser/ui/webui/uber/uber_ui.cc
@@ -108,7 +108,7 @@ content::WebUIDataSource* CreateUberFrameHTMLSource(Profile* profile) {
                             IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
  source->AddString("helpHost",
                    ASCIIToUTF16(chrome::kChromeUIHelpHost));
-  source->AddLocalizedString("helpDisplayName", IDS_HELP_TITLE);
+  source->AddLocalizedString("helpDisplayName", IDS_ABOUT_TITLE);
  source->AddString("historyHost",
                    ASCIIToUTF16(chrome::kChromeUIHistoryHost));
  source->AddLocalizedString("historyDisplayName", IDS_HISTORY_TITLE);