Commit dc7bac19 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Minimize dependencies for components/crash/content/app.

Only depend on content/public/common when building for Chrome OS. Since
that is the only time when the dependency is actually needed.

Bug: 990184
Change-Id: Ie7e04f317510b3bcb099acfb81379919b96ffccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732389Reviewed-by: default avatarJ Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683764}
parent da3d9552
...@@ -95,13 +95,14 @@ static_library("app") { ...@@ -95,13 +95,14 @@ static_library("app") {
"//content/public/common:result_codes", "//content/public/common:result_codes",
"//sandbox", "//sandbox",
] ]
}
if (is_linux) { if (is_linux) {
deps += [ deps += [ "//third_party/breakpad:client" ]
"//content/public/common", }
"//third_party/breakpad:client",
] if (is_chromeos) {
} deps += [ "//content/public/common" ]
} }
if (is_win) { if (is_win) {
......
...@@ -45,8 +45,6 @@ ...@@ -45,8 +45,6 @@
#include "components/crash/content/app/crash_reporter_client.h" #include "components/crash/content/app/crash_reporter_client.h"
#include "components/crash/core/common/crash_keys.h" #include "components/crash/core/common/crash_keys.h"
#include "content/public/common/content_descriptors.h" #include "content/public/common/content_descriptors.h"
#include "content/public/common/content_switches.h"
#include "services/service_manager/embedder/switches.h"
#include "third_party/breakpad/breakpad/src/client/linux/crash_generation/crash_generation_client.h" #include "third_party/breakpad/breakpad/src/client/linux/crash_generation/crash_generation_client.h"
#include "third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.h" #include "third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.h"
#include "third_party/breakpad/breakpad/src/client/linux/minidump_writer/directory_reader.h" #include "third_party/breakpad/breakpad/src/client/linux/minidump_writer/directory_reader.h"
...@@ -64,6 +62,11 @@ ...@@ -64,6 +62,11 @@
#endif #endif
#include "third_party/lss/linux_syscall_support.h" #include "third_party/lss/linux_syscall_support.h"
#if defined(OS_CHROMEOS)
#include "content/public/common/content_switches.h" // nogncheck
#include "services/service_manager/embedder/switches.h" // nogncheck
#endif
#if defined(ADDRESS_SANITIZER) #if defined(ADDRESS_SANITIZER)
#include <ucontext.h> // for getcontext(). #include <ucontext.h> // for getcontext().
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment