Commit dcdd5935 authored by Gabriel Charette's avatar Gabriel Charette

[TaskScheduler] Also add temporary forward headers for scheduler_worker_(pool_)?params.h

And fix one more missing migration.

TBR=skyostil@chromium.org

Bug: 867421
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0e7ff198c8fef8ac223025c93df08cdaedc79164
Reviewed-on: https://chromium-review.googlesource.com/1163282
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580785}
parent 43215b1f
......@@ -860,6 +860,8 @@ jumbo_component("base") {
"task/sequence_manager/work_queue_sets.h",
"task/single_thread_task_runner_thread_mode_forward.h",
"task/task_scheduler/initialization_util_forward.h",
"task/task_scheduler/scheduler_worker_params_forward.h",
"task/task_scheduler/scheduler_worker_pool_params_forward.h",
"task/task_scheduler/task_scheduler_forward.h",
"task/task_traits_forward.h",
"task_runner.cc",
......
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_PARAMS_FORWARD_H_
#define BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_PARAMS_FORWARD_H_
// If you are seeing this you synced to a very short-lived state in the task
// scheduler's header migration. To keep as much git history as possible while
// avoiding a mass header rename in thousands of file in the main move CL,
// base/task_scheduler's public headers were moved this way :
// for each base/task_scheduler/public.h:
// A.1) Introduce base/task/public_forward.h and move the world to use it
// A.2) Move base/task_scheduler/public.h to base/task/public.h (and update
// forwarding headers)
// A.3) Delete base/task/public_forward.h (move world to base/task/public.h).
//
// An alternative would have been:
// B.1) Move base/task_scheduler/public.h to base/task/public.h and leave
// a stub fowarding header in base/task_scheduler/public.h
// B.2) Migrate world from base/task_scheduler/public.h to base/task/public.h
// and delete stub.
// That approach however results in git not considering base/task/public.h as
// being a new file rather than a move in (B.1) and losing all history.
//
// Another alternative would have been:
// C.1) Introduce base/task/public.h as a forwarding header and move the world
// to it
// C.2) Move base/task_scheduler/public.h over base/task/public.h
// That approach also results in git not considering (C.2) a file move (per
// overriding an existing file) and losing all history.
//
// As such approach A was preferred : the landing process will wait for all 3
// CLs to be LGTM'ed in approach A and then land them switfly back-to-back.
#include "base/task/task_scheduler/scheduler_worker_params_forward.h"
#endif // BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_PARAMS_FORWARD_H_
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_FORWARD_H_
#define BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_FORWARD_H_
// If you are seeing this you synced to a very short-lived state in the task
// scheduler's header migration. To keep as much git history as possible while
// avoiding a mass header rename in thousands of file in the main move CL,
// base/task_scheduler's public headers were moved this way :
// for each base/task_scheduler/public.h:
// A.1) Introduce base/task/public_forward.h and move the world to use it
// A.2) Move base/task_scheduler/public.h to base/task/public.h (and update
// forwarding headers)
// A.3) Delete base/task/public_forward.h (move world to base/task/public.h).
//
// An alternative would have been:
// B.1) Move base/task_scheduler/public.h to base/task/public.h and leave
// a stub fowarding header in base/task_scheduler/public.h
// B.2) Migrate world from base/task_scheduler/public.h to base/task/public.h
// and delete stub.
// That approach however results in git not considering base/task/public.h as
// being a new file rather than a move in (B.1) and losing all history.
//
// Another alternative would have been:
// C.1) Introduce base/task/public.h as a forwarding header and move the world
// to it
// C.2) Move base/task_scheduler/public.h over base/task/public.h
// That approach also results in git not considering (C.2) a file move (per
// overriding an existing file) and losing all history.
//
// As such approach A was preferred : the landing process will wait for all 3
// CLs to be LGTM'ed in approach A and then land them switfly back-to-back.
#include "base/task/task_scheduler/scheduler_worker_pool_params_forward.h"
#endif // BASE_TASK_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_FORWARD_H_
......@@ -24,8 +24,8 @@
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/post_task_forward.h"
#include "base/task/task_scheduler/scheduler_worker_pool_params_forward.h"
#include "base/task/task_scheduler/task_scheduler_forward.h"
#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "base/values.h"
......
......@@ -9,8 +9,8 @@
#include "base/macros.h"
#include "base/metrics/field_trial.h"
#include "base/task_scheduler/scheduler_worker_params.h"
#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/task/task_scheduler/scheduler_worker_params_forward.h"
#include "base/task/task_scheduler/scheduler_worker_pool_params_forward.h"
#include "components/variations/variations_params_manager.h"
#include "testing/gtest/include/gtest/gtest.h"
......
......@@ -17,8 +17,8 @@
#include "base/power_monitor/power_monitor.h"
#include "base/power_monitor/power_monitor_device_source.h"
#include "base/process/process_metrics.h"
#include "base/task/task_scheduler/scheduler_worker_pool_params_forward.h"
#include "base/task/task_scheduler/task_scheduler_forward.h"
#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/threading/thread_restrictions.h"
#import "ios/web/net/cookie_notification_bridge.h"
#include "ios/web/public/app/web_main_parts.h"
......
......@@ -43,7 +43,7 @@
#include "base/at_exit.h"
#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/task_scheduler/task_scheduler.h"
#include "base/task/task_scheduler/task_scheduler_forward.h"
#include "net/base/net_errors.h"
#include "net/base/privacy_mode.h"
#include "net/cert/cert_verifier.h"
......
......@@ -13,7 +13,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/task_scheduler/task_scheduler.h"
#include "base/task/task_scheduler/task_scheduler_forward.h"
#include "net/quic/crypto/proof_source_chromium.h"
#include "net/third_party/quic/core/quic_packets.h"
#include "net/third_party/quic/platform/api/quic_socket_address.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment