Commit dce9f016 authored by Dominic Farolino's avatar Dominic Farolino Committed by Commit Bot

Revert "Add referrer DumpWithoutCrash to WebURLLoaderImpl"

This reverts commit 04dc0257.

Reason for revert: This was a debugging CL to help get information on a DumpWithoutCrash.

Original change's description:
> Add referrer DumpWithoutCrash to WebURLLoaderImpl
> 
> The network service's
> OnCancelURLRequestWithPolicyViolatingReferrerHeader method is called
> after it has been determined that a URLRequest's referrer does not match
> what the policy demands. This method performs a DumpWithoutCrash for
> debugging. However, this is called within the network service, so the
> path of the request's creation is not captured in the stack trace,
> making it less useful.
> 
> This CL checks whether or not a request's referrer matches what its
> policy demands earlier, when a network::ResourceRequest is created by
> WebURLLoaderImpl. This captures a better picture of a renderer-initiated
> request's origins in the stack trace, which is much more useful for
> debugging.
> 
> Bug: 1004083
> Change-Id: I867e488a860e2ac042a1eb93bff04e5f10a3126e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803936
> Commit-Queue: Dominic Farolino <dom@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#696684}

TBR=yhirano@chromium.org,mmenke@chromium.org,dom@chromium.org

Change-Id: If4759af2fa77deb36fd36a75b0a09f496f06a79f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1004083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806617Reviewed-by: default avatarDominic Farolino <dom@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696772}
parent 55da808c
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/callback.h" #include "base/callback.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/logging.h" #include "base/logging.h"
...@@ -57,7 +56,6 @@ ...@@ -57,7 +56,6 @@
#include "net/ssl/ssl_connection_status_flags.h" #include "net/ssl/ssl_connection_status_flags.h"
#include "net/ssl/ssl_info.h" #include "net/ssl/ssl_info.h"
#include "net/url_request/url_request_data_job.h" #include "net/url_request/url_request_data_job.h"
#include "net/url_request/url_request_job.h"
#include "services/network/loader_util.h" #include "services/network/loader_util.h"
#include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/resource_request.h"
#include "services/network/public/mojom/url_loader.mojom.h" #include "services/network/public/mojom/url_loader.mojom.h"
...@@ -662,29 +660,10 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request, ...@@ -662,29 +660,10 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
} }
if (!request.IsolatedWorldOrigin().IsNull()) if (!request.IsolatedWorldOrigin().IsNull())
resource_request->isolated_world_origin = request.IsolatedWorldOrigin(); resource_request->isolated_world_origin = request.IsolatedWorldOrigin();
resource_request->referrer = referrer_url; resource_request->referrer = referrer_url;
resource_request->referrer_policy = resource_request->referrer_policy =
Referrer::ReferrerPolicyForUrlRequest(request.GetReferrerPolicy()); Referrer::ReferrerPolicyForUrlRequest(request.GetReferrerPolicy());
// Record information to help debug issues like http://crbug.com/422871. We
// perform this check here, before the request is passed to the network
// service, because the stack trace here has more information regarding the
// request's origins.
if (resource_request->referrer !=
net::URLRequestJob::ComputeReferrerForPolicy(
resource_request->referrer_policy, resource_request->referrer,
resource_request->request_initiator.value_or(url::Origin()),
resource_request->url)) {
if (resource_request->url.SchemeIsHTTPOrHTTPS()) {
auto referrer_policy = resource_request->referrer_policy;
base::debug::Alias(&referrer_policy);
DEBUG_ALIAS_FOR_GURL(target_buf, resource_request->url);
DEBUG_ALIAS_FOR_GURL(referrer_buf, resource_request->referrer);
base::debug::DumpWithoutCrashing();
}
}
resource_request->resource_type = resource_request->resource_type =
static_cast<int>(WebURLRequestToResourceType(request)); static_cast<int>(WebURLRequestToResourceType(request));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment