Commit dd0f0eac authored by khachatryan's avatar khachatryan Committed by Commit Bot

[ChromeDriver] Add Chrome v72, drop Chrome v69

We are adding ChromeDriver support for Chrome v72
and dropping support for Chrome v69

Change-Id: I3424e451bf596eeab5052cbe6f1c79557d11649b
Reviewed-on: https://chromium-review.googlesource.com/c/1359061Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613243}
parent d7ab018d
......@@ -9,7 +9,7 @@
namespace {
// This variable must be able to be found and parsed by the upload script.
const int kMinimumSupportedChromeVersion[] = {69, 0, 3497, 0};
const int kMinimumSupportedChromeVersion[] = {70, 0, 3538, 0};
} // namespace
......
......@@ -217,21 +217,21 @@ def main():
versions = {'HEAD': archive.GetLatestRevision()}
# Linux64 build numbers
if util.IsLinux():
versions['72'] = '612434'
versions['71'] = '599034'
versions['70'] = '587811'
versions['69'] = '576753'
# Mac build numbers
elif util.IsMac():
versions['72'] = '612451'
versions['71'] = '599028'
versions['70'] = '587811'
versions['69'] = '576753'
# Windows build numbers
elif util.IsWindows():
versions['72'] = '612432'
versions['71'] = '598927'
versions['70'] = '587814'
versions['69'] = '576753'
code = 0
for version, revision in versions.iteritems():
......
......@@ -98,21 +98,19 @@ _VERSION_SPECIFIC_FILTER['HEAD'] = [
'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout',
]
_VERSION_SPECIFIC_FILTER['71'] = [
_VERSION_SPECIFIC_FILTER['72'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2532
'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout',
]
_VERSION_SPECIFIC_FILTER['70'] = [
_VERSION_SPECIFIC_FILTER['71'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2532
'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout',
# Feature not yet supported in this version
'ChromeDriverTest.testGenerateTestReport',
]
_VERSION_SPECIFIC_FILTER['69'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2515
'HeadlessInvalidCertificateTest.*',
_VERSION_SPECIFIC_FILTER['70'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2532
'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout',
# Feature not yet supported in this version
'ChromeDriverTest.testGenerateTestReport',
]
......
......@@ -48,12 +48,6 @@ _OS_NEGATIVE_FILTER['mac'] = [
]
_SPECIFIC_OS_REVISION_NEGATIVE_FILTER = {}
_SPECIFIC_OS_REVISION_NEGATIVE_FILTER['mac_69'] = [
# Maximize window doesn't always increase window size on Mac 69
'WindowTest.testCanMaximizeTheWindowFromFrame',
'WindowTest.testCanMaximizeTheWindowFromIframe',
'WindowTest.testCanMaximizeTheWindow',
]
_OS_NEGATIVE_FILTER['android:chrome'] = [
'ChromeOptionsFunctionalTest.*',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment