Remove allowed_to_download from frame policy

This was previously used to cache the effect of the
"download-without-user-activation" policy, but since the removal of
FeaturePolicyForSandbox, it is no longer read anywhere, so this is all dead code.

Change-Id: I9eb574d447cabcfa7d9499366aa498bc9c7985c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575100
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#834704}

content/common/frame_messages.h

@@ -176,7 +176,6 @@ IPC_STRUCT_TRAITS_BEGIN(blink::FramePolicy)
   IPC_STRUCT_TRAITS_MEMBER(sandbox_flags)
   IPC_STRUCT_TRAITS_MEMBER(container_policy)
   IPC_STRUCT_TRAITS_MEMBER(required_document_policy)
-  IPC_STRUCT_TRAITS_MEMBER(allowed_to_download)
   IPC_STRUCT_TRAITS_MEMBER(disallow_document_access)
 IPC_STRUCT_TRAITS_END()
 

content/test/test_render_frame_host.cc

@@ -153,7 +153,7 @@ TestRenderFrameHost* TestRenderFrameHost::AppendChildWithPolicy(
       blink::mojom::TreeScopeType::kDocument, frame_name, frame_unique_name,
       false, base::UnguessableToken::Create(), base::UnguessableToken::Create(),
       blink::FramePolicy(
-          {network::mojom::WebSandboxFlags::kNone, allow, {}, true, false}),
+          {network::mojom::WebSandboxFlags::kNone, allow, {}, false}),
       blink::mojom::FrameOwnerProperties(),
       blink::mojom::FrameOwnerElementType::kIframe);
   return static_cast<TestRenderFrameHost*>(

third_party/blink/common/frame/frame_policy.cc

@@ -11,19 +11,16 @@ FramePolicy::FramePolicy()
     : sandbox_flags(network::mojom::WebSandboxFlags::kNone),
       container_policy({}),
       required_document_policy({}),
-      allowed_to_download(true),
       disallow_document_access(false) {}
 
 FramePolicy::FramePolicy(
     network::mojom::WebSandboxFlags sandbox_flags,
     const ParsedFeaturePolicy& container_policy,
     const DocumentPolicyFeatureState& required_document_policy,
-    bool allowed_to_download,
     bool disallow_document_access)
     : sandbox_flags(sandbox_flags),
       container_policy(container_policy),
       required_document_policy(required_document_policy),
-      allowed_to_download(allowed_to_download),
       disallow_document_access(disallow_document_access) {}
 
 FramePolicy::FramePolicy(const FramePolicy& lhs) = default;

third_party/blink/common/frame/frame_policy_mojom_traits.cc

@@ -9,7 +9,6 @@ namespace mojo {
 bool StructTraits<blink::mojom::FramePolicyDataView, blink::FramePolicy>::Read(
     blink::mojom::FramePolicyDataView in,
     blink::FramePolicy* out) {
-  out->allowed_to_download = in.allowed_to_download();
   out->disallow_document_access = in.disallow_document_access();
 
   // TODO(chenleihu): Add sanity check on enum values in

third_party/blink/common/frame/frame_policy_mojom_traits.h

@@ -16,10 +16,6 @@ template <>
 class BLINK_COMMON_EXPORT
     StructTraits<blink::mojom::FramePolicyDataView, blink::FramePolicy> {
  public:
-  static bool allowed_to_download(const blink::FramePolicy& frame_policy) {
-    return frame_policy.allowed_to_download;
-  }
-
   static bool disallow_document_access(const blink::FramePolicy& frame_policy) {
     return frame_policy.disallow_document_access;
   }

third_party/blink/public/common/frame/frame_policy.h

@@ -28,7 +28,6 @@ struct BLINK_COMMON_EXPORT FramePolicy {
   FramePolicy(network::mojom::WebSandboxFlags sandbox_flags,
               const ParsedFeaturePolicy& container_policy,
               const DocumentPolicyFeatureState& required_document_policy,
-              bool allowed_to_download = true,
               bool disallow_document_access = false);
   FramePolicy(const FramePolicy& lhs);
   ~FramePolicy();
@@ -40,14 +39,6 @@ struct BLINK_COMMON_EXPORT FramePolicy {
   // - 'Require-Document-Policy' http header
   // - |required_document_policy| of parent frame
   DocumentPolicyFeatureState required_document_policy;
-  // With FeaturePolicyForSandbox, as a policy affecting the document,
-  // "downloads" is included in |container_policy|.
-  // However, in certain cases where the initiator of the navigation is not the
-  // document itself (e.g., a parent document), the FrameOwner element should be
-  // checked for "downloads" flag. If this boolean is false then navigations
-  // leading to downloads should be blocked. Note: this flag is currently only
-  // set if the frame is sandboxed for downloads.
-  bool allowed_to_download;
 
   // Whether or not a frame allows direct script access across frame
   // boundaries.

third_party/blink/public/mojom/frame/frame_policy.mojom

@@ -18,6 +18,5 @@ struct FramePolicy {
   network.mojom.WebSandboxFlags sandbox_flags;
   array<blink.mojom.ParsedFeaturePolicyDeclaration> container_policy;
   map<blink.mojom.DocumentPolicyFeature, blink.mojom.PolicyValue> required_document_policy;
-  bool allowed_to_download = true;
   bool disallow_document_access = false;
 };

third_party/blink/renderer/core/html/html_frame_owner_element.h

@@ -138,9 +138,6 @@ class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
   HTMLFrameOwnerElement(const QualifiedName& tag_name, Document&);
 
   void SetSandboxFlags(network::mojom::blink::WebSandboxFlags);
-  void SetAllowedToDownload(bool allowed) {
-    frame_policy_.allowed_to_download = allowed;
-  }
   void SetDisallowDocumentAccesss(bool disallowed);
 
   bool LoadOrRedirectSubframe(const KURL&,

third_party/blink/renderer/core/html/html_iframe_element.cc

@@ -175,9 +175,6 @@ void HTMLIFrameElement::ParseAttribute(
                 parsed.error_message)));
       }
     }
-    SetAllowedToDownload(
-        (current_flags & network::mojom::blink::WebSandboxFlags::kDownloads) ==
-        network::mojom::blink::WebSandboxFlags::kNone);
     SetSandboxFlags(current_flags);
     UseCounter::Count(GetDocument(), WebFeature::kSandboxViaIFrame);
   } else if (name == html_names::kReferrerpolicyAttr) {